Skip to content

Convert actions to Ubuntu 24.04 #3664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marksvc merged 2 commits into from
Apr 2, 2026
Merged

Convert actions to Ubuntu 24.04 #3664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44e3440
Convert actions to Ubuntu 24.04
Nateowami Feb 2, 2026
44985b8
Merge branch 'master' into test/2024-04-actions
marksvc Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
matrix:
# Environments in which to run, such as those used in development and production, or which are candidates to
# move to.
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
dotnet_version: ["8.0.x"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
name: "Production build and test"
strategy:
matrix:
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 chromium-browser command does not exist on Ubuntu 24.04, breaking production build CI

Same issue as in the build-development job, but in the build-production job. The "Pre-build report" step at .github/workflows/build-and-test.yml:180-181 references chromium-browser, which does not exist on Ubuntu 24.04. With set -xueo pipefail, this will fail the workflow.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

dotnet_version: ["8.0.x"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/chromatic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
name: "Deploy Storybook to Chromatic"
strategy:
matrix:
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
runs-on: ${{matrix.os}}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compute-next-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ on:
jobs:
deploy:
name: "Compute next version"
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
next_version: ${{ steps.compute_next_version.outputs.next_version }}
steps:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
name: "Prepare Realtime Server backend"
strategy:
matrix:
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
dotnet_version: ["8.0.x"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
needs: [prepare-realtimeserver-backend]
strategy:
matrix:
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
dotnet_version: ["8.0.x"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:
needs: [prepare-realtimeserver-backend]
strategy:
matrix:
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
dotnet_version: ["8.0.x"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
Expand Down Expand Up @@ -230,7 +230,7 @@ jobs:
needs: [prepare-realtimeserver-backend]
strategy:
matrix:
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
dotnet_version: ["8.0.x"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
Expand Down Expand Up @@ -291,7 +291,7 @@ jobs:
environment: "e2e_tests"
strategy:
matrix:
os: ["ubuntu-22.04"]
os: ["ubuntu-24.04"]
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot Mar 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 chromium-browser references may need updating for Ubuntu 24.04 compatibility

The pre-build report steps in build-and-test.yml:65-66 and build-and-test.yml:180-181 run which chromium-browser and chromium-browser --version under set -xueo pipefail. On standard Ubuntu 24.04, chromium-browser is a transitional package that redirects to the snap chromium package, and the binary name is typically chromium rather than chromium-browser. GitHub Actions runner images for ubuntu-24.04 may provide chromium-browser through a third-party PPA (e.g., chromium-team/stable), which would make the command available. However, this depends on the runner image's specific configuration and PPA support for Noble (24.04). If chromium-browser is not available, the step will fail due to set -e, blocking the entire CI pipeline. Additionally, the test:gha npm script at src/SIL.XForge.Scripture/ClientApp/package.json:17 uses xForgeChromiumHeadless (based on ChromiumHeadless from karma-chrome-launcher), which also looks for chromium-browser in PATH. Worth verifying these commands work on the new runner image.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Copy link
Copy Markdown
Collaborator

@marksvc marksvc Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a problem. And the E2E build passed.

dotnet_version: ["8.0.x"]
node_version: ["22.13.0"]
npm_version: ["11.11.0"]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release-live.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ on:
jobs:
determine_build_commit:
name: "Determine commit from which to build"
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
build_commit: "${{ steps.get_commit.outputs.build_commit }}"
steps:
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
node_version: "22.13.0"
npm_version: "11.11.0"
# When bumping OS version, the server will need to authorize the new default rsync args.
os: "ubuntu-22.04"
os: "ubuntu-24.04"
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 rsync compatibility warning: server may need reconfiguration for ubuntu-24.04

The existing comments at release-live.yml:120 and release-qa.yml:141 explicitly warn: "When bumping OS version, the server will need to authorize the new default rsync args." This PR bumps the OS version from ubuntu-22.04 to ubuntu-24.04, which is exactly the scenario the comment warns about. Ubuntu 24.04 ships rsync 3.2.7+ which may use different default arguments (e.g., different compression or checksum algorithms like xxhash) compared to Ubuntu 22.04's rsync. If the deployment server uses rrsync or other restrictions on allowed rsync arguments, the deploy step in release.yml:163 (scripts/build-and-ship) could fail. The server-side configuration should be verified before deploying from an ubuntu-24.04 runner.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


angular_config: "production"
app_name: "scriptureforge"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release-qa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ on:
jobs:
determine_build_commit:
name: "Determine commit from which to build"
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
build_commit: "${{ steps.get_commit.outputs.build_commit }}"
steps:
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
needs: determine_build_commit
outputs:
already_built: "${{ steps.check_if_already_built.outputs.already_built }}"
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout repository
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down Expand Up @@ -139,7 +139,7 @@ jobs:
node_version: "22.13.0"
npm_version: "11.11.0"
# When bumping OS version, the server will need to authorize the new default rsync args.
os: "ubuntu-22.04"
os: "ubuntu-24.04"

angular_config: "staging"
app_name: "scriptureforge"
Expand Down
Loading