SF-3617 Detect books without content and exclude from drafting option#3660
Merged
RaymondLuong3 merged 1 commit intomasterfrom Feb 4, 2026
Merged
SF-3617 Detect books without content and exclude from drafting option#3660RaymondLuong3 merged 1 commit intomasterfrom
RaymondLuong3 merged 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3660 +/- ##
=======================================
Coverage 81.95% 81.96%
=======================================
Files 618 618
Lines 38495 38520 +25
Branches 6300 6302 +2
=======================================
+ Hits 31549 31571 +22
- Misses 5972 5977 +5
+ Partials 974 972 -2 ☔ View full report in Codecov by Sentry. |
pmachapman
approved these changes
Feb 1, 2026
Collaborator
pmachapman
left a comment
There was a problem hiding this comment.
@pmachapman reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).
3dacece to
9f15eba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds logic to determine whether a training book should be selectable as training data. It looks at the target and training source project progress and evaluates whether the specific book has the minimum number of translated verses (3 verse segments).
It is still possible to select training books that have zero overlap in the translated verses, but this is will improve user experience when they accidentally select books that are fully blank. We may want to bump up the minimum number of translated verses to 50% of a book, but that is a different discussion.
This change is