Skip to content

SF-3617 Detect books without content and exclude from drafting option#3660

Merged
RaymondLuong3 merged 1 commit intomasterfrom
improvement/sf-3617-book-no-content
Feb 4, 2026
Merged

SF-3617 Detect books without content and exclude from drafting option#3660
RaymondLuong3 merged 1 commit intomasterfrom
improvement/sf-3617-book-no-content

Conversation

@RaymondLuong3
Copy link
Copy Markdown
Collaborator

@RaymondLuong3 RaymondLuong3 commented Jan 30, 2026

This PR adds logic to determine whether a training book should be selectable as training data. It looks at the target and training source project progress and evaluates whether the specific book has the minimum number of translated verses (3 verse segments).
It is still possible to select training books that have zero overlap in the translated verses, but this is will improve user experience when they accidentally select books that are fully blank. We may want to bump up the minimum number of translated verses to 50% of a book, but that is a different discussion.

image

This change is Reviewable

@RaymondLuong3 RaymondLuong3 added the will require testing PR should not be merged until testers confirm testing is complete label Jan 30, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.96%. Comparing base (eda080f) to head (9f15eba).
⚠️ Report is 77 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...neration-steps/draft-generation-steps.component.ts 94.59% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3660   +/-   ##
=======================================
  Coverage   81.95%   81.96%           
=======================================
  Files         618      618           
  Lines       38495    38520   +25     
  Branches     6300     6302    +2     
=======================================
+ Hits        31549    31571   +22     
- Misses       5972     5977    +5     
+ Partials      974      972    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman self-requested a review February 1, 2026 18:39
@pmachapman pmachapman self-assigned this Feb 1, 2026
Copy link
Copy Markdown
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Feb 1, 2026
@RaymondLuong3 RaymondLuong3 force-pushed the improvement/sf-3617-book-no-content branch from 3dacece to 9f15eba Compare February 4, 2026 21:23
@RaymondLuong3 RaymondLuong3 merged commit 1202640 into master Feb 4, 2026
23 checks passed
@RaymondLuong3 RaymondLuong3 deleted the improvement/sf-3617-book-no-content branch February 4, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants