Improve versification warnings for invalid chapters and verses#871
Improve versification warnings for invalid chapters and verses#871
Conversation
Enkidu93
left a comment
There was a problem hiding this comment.
If we can add an expected ref on the machine side, that'll need to be added here as well; otherwise,
@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit).
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @pmachapman).
2e848c0 to
dfcd00f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
==========================================
- Coverage 66.96% 66.96% -0.01%
==========================================
Files 384 384
Lines 20878 20886 +8
Branches 2699 2700 +1
==========================================
+ Hits 13981 13986 +5
- Misses 5934 5936 +2
- Partials 963 964 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Second part of fix for sillsdev/machine#372. Requires sillsdev/machine#381 (the CI will fail until that PR is merged).
Example warnings:
This change is