Skip to content

Improve versification warnings for invalid chapters and verses#871

Merged
Enkidu93 merged 3 commits intomainfrom
invalid_chapter_warnings
Feb 13, 2026
Merged

Improve versification warnings for invalid chapters and verses#871
Enkidu93 merged 3 commits intomainfrom
invalid_chapter_warnings

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Feb 9, 2026

Second part of fix for sillsdev/machine#372. Requires sillsdev/machine#381 (the CI will fail until that PR is merged).

Example warnings:

warnings: [
  "Invalid chapter number error in project TEA at “MAN 1.” (parallel corpus 69893d8434467c056f3542e5, monolingual corpus 69893d8334467c056f3542e1)",
  "Invalid verse number error in project TEA at “LAO 1:v1” (parallel corpus 69893d8434467c056f3542e5, monolingual corpus 69893d8334467c056f3542e1)"
]

This change is Reviewable

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can add an expected ref on the machine side, that'll need to be added here as well; otherwise,
:lgtm:

@Enkidu93 reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit).

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman).

@Enkidu93 Enkidu93 force-pushed the invalid_chapter_warnings branch from 2e848c0 to dfcd00f Compare February 13, 2026 20:15
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.96%. Comparing base (51e46dc) to head (fb9f2f7).

Files with missing lines Patch % Lines
...rval.Machine.Shared/Services/PreprocessBuildJob.cs 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   66.96%   66.96%   -0.01%     
==========================================
  Files         384      384              
  Lines       20878    20886       +8     
  Branches     2699     2700       +1     
==========================================
+ Hits        13981    13986       +5     
- Misses       5934     5936       +2     
- Partials      963      964       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Enkidu93 Enkidu93 merged commit 55e3b1a into main Feb 13, 2026
1 of 2 checks passed
@Enkidu93 Enkidu93 deleted the invalid_chapter_warnings branch February 13, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants