Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 66.51% 66.57% +0.05%
==========================================
Files 382 383 +1
Lines 20896 20933 +37
Branches 2720 2720
==========================================
+ Hits 13900 13937 +37
Misses 6027 6027
Partials 969 969 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
ddaspit
left a comment
There was a problem hiding this comment.
How easy would it be to write a test for this? We could pull this out into a separate function and add a test. We do start up a MongoDB instance for testing on GHA.
@ddaspit made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
Enkidu93
left a comment
There was a problem hiding this comment.
I've attempted to add a test - since this is the first of its kind, I'm not sure about file structure etc. Let me know what you think.
@Enkidu93 made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @ddaspit).
ddaspit
left a comment
There was a problem hiding this comment.
That is perfect for now. If we move to something more structured, we can refactor it.
@ddaspit reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
083b1da to
a16afd8
Compare
This has been tested more carefully locally and I previewed the pipeline in atlas as well but I'd still appreciate another set of eyes. I'm sorry for the headache! It's easier than I thought to mistake an object for an array.
This change is