Skip to content

Fix migration#865

Merged
Enkidu93 merged 3 commits intomainfrom
fix_migration
Feb 3, 2026
Merged

Fix migration#865
Enkidu93 merged 3 commits intomainfrom
fix_migration

Conversation

@Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Feb 2, 2026

This has been tested more carefully locally and I previewed the pipeline in atlas as well but I'd still appreciate another set of eyes. I'm sorry for the headache! It's easier than I thought to mistake an object for an array.


This change is Reviewable

@Enkidu93 Enkidu93 requested a review from ddaspit February 2, 2026 22:20
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.57%. Comparing base (214b1e1) to head (a16afd8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   66.51%   66.57%   +0.05%     
==========================================
  Files         382      383       +1     
  Lines       20896    20933      +37     
  Branches     2720     2720              
==========================================
+ Hits        13900    13937      +37     
  Misses       6027     6027              
  Partials      969      969              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How easy would it be to write a test for this? We could pull this out into a separate function and add a test. We do start up a MongoDB instance for testing on GHA.

@ddaspit made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).

Copy link
Collaborator Author

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've attempted to add a test - since this is the first of its kind, I'm not sure about file structure etc. Let me know what you think.

@Enkidu93 made 1 comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @ddaspit).

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is perfect for now. If we move to something more structured, we can refactor it.

@ddaspit reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).

@Enkidu93 Enkidu93 merged commit bcb72c7 into main Feb 3, 2026
2 of 3 checks passed
@Enkidu93 Enkidu93 deleted the fix_migration branch February 3, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants