Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
==========================================
+ Coverage 90.68% 90.75% +0.07%
==========================================
Files 355 355
Lines 22508 22677 +169
==========================================
+ Hits 20411 20581 +170
+ Misses 2097 2096 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit partially reviewed 19 files and all commit messages, and made 2 comments.
Reviewable status: 19 of 20 files reviewed, 2 unresolved discussions (waiting on @Enkidu93).
machine/corpora/scripture_ref_usfm_parser_handler_base.py line 28 at r1 (raw file):
def is_private_use_marker(marker: str):
This function is private to the module, i.e. you should prefix with an underscore.
machine/corpora/update_usfm_parser_handler.py line 41 at r1 (raw file):
def sanitize_verse_data(verse_data: str) -> str:
This function is private to the module.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 1 file and made 1 comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Enkidu93).
machine/scripture/verse_ref.py line 152 at r1 (raw file):
@verse_num.setter def verse_num(self, value: int) -> None: if value < 0:
Why do we need to remove this check? It deviates from the C# code.
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 made 3 comments.
Reviewable status: 19 of 21 files reviewed, 3 unresolved discussions (waiting on @ddaspit).
machine/corpora/update_usfm_parser_handler.py line 41 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This function is private to the module.
Done.
machine/scripture/verse_ref.py line 152 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
Why do we need to remove this check? It deviates from the C# code.
We do not need to. I misread and thought this check was on the verse setter which (for better or worse) is settable to something like -1. I reverted it.
machine/corpora/scripture_ref_usfm_parser_handler_base.py line 28 at r1 (raw file):
Previously, ddaspit (Damien Daspit) wrote…
This function is private to the module, i.e. you should prefix with an underscore.
Done.
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit partially reviewed 5 files and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
|
Fixes #265 |
Hopefully there aren't too many things we've missed along the way. There are fewer things that need to be ported to Machine from machine.py luckily although I was surprised to discover that #141 has never been ported 🤪.
This change is