Add Swagger and GraphQL UI links for developers#2125
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughAppBar gained developer action buttons (Sandbox, Swagger UI, GraphQL UI); Layout removed a now-duplicated sandbox button. ESLint output config files and package/workspace entries for Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
UI unit Tests 1 files ± 0 3 suites - 44 0s ⏱️ -19s Results for commit 2554956. ± Comparison against base commit 77d4c51. This pull request removes 123 and adds 10 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@frontend/src/lib/layout/AppBar.svelte`:
- Around line 52-59: The onclick handlers currently call
window.open('/api/swagger', '_blank') and window.open('/api/graphql/ui',
'_blank') which can leak window.opener; update both window.open calls (the
onclick attributes on the IconButton elements) to pass the noopener,noreferrer
feature string (e.g., window.open(url, '_blank', 'noopener,noreferrer')) so new
tabs are opened with noopener and noreferrer protection.
- Around line 47-60: The two icon-only IconButton instances (the ones with
icon="i-mdi-api" and icon="i-mdi-graphql") are missing accessible names; add an
explicit aria-label prop to each (for example aria-label="Open Swagger" and
aria-label="Open GraphQL") so screen readers get a proper name instead of
relying on title; this leverages the IconButton prop forwarding (...rest) so no
component changes are required.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/src/lib/layout/AppBar.svelte
🧰 Additional context used
📓 Path-based instructions (2)
frontend/**/*.svelte
📄 CodeRabbit inference engine (frontend/AGENTS.md)
frontend/**/*.svelte: Use DaisyUI classes for consistent styling in Svelte components
Import icons from$lib/icons/for icon components
Files:
frontend/src/lib/layout/AppBar.svelte
frontend/**/*.{ts,tsx,svelte}
📄 CodeRabbit inference engine (AGENTS.md)
Use
pnpm devfor starting the frontend development server in SvelteKit
Files:
frontend/src/lib/layout/AppBar.svelte
🧠 Learnings (2)
📚 Learning: 2025-12-05T10:28:57.551Z
Learnt from: CR
Repo: sillsdev/languageforge-lexbox PR: 0
File: frontend/viewer/AGENTS.md:0-0
Timestamp: 2025-12-05T10:28:57.551Z
Learning: Applies to frontend/viewer/**/*.svelte : Use ShadCN-Svelte (Tailwind-based) for UI components
Applied to files:
frontend/src/lib/layout/AppBar.svelte
📚 Learning: 2025-12-05T10:28:45.596Z
Learnt from: CR
Repo: sillsdev/languageforge-lexbox PR: 0
File: frontend/AGENTS.md:0-0
Timestamp: 2025-12-05T10:28:45.596Z
Learning: Applies to frontend/**/*.svelte : Import icons from `$lib/icons/` for icon components
Applied to files:
frontend/src/lib/layout/AppBar.svelte
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build UI / publish-ui
- GitHub Check: Build API / publish-api
- GitHub Check: check-and-lint
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
8818481 to
0ae70be
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎ Awaiting the start of a new Argos build… |
e5fe2cc to
f14285e
Compare
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
1 similar comment
✅ Actions performedFull review triggered. |
f14285e to
2554956
Compare
|
@myieye Those look like a handy couple new dev buttons. Worth adding them to https://github.com/sillsdev/languageforge-lexbox/blob/develop/frontend/viewer/src/home/HomeView.svelte#L157-L159 too? |
Hey! No, they're Lexbox only links, so they don't really make sense in FWLite. |
Ah, yes. However, just |
|
@imnasnainaec You're right! I've almost not used the FwLite REST API, because fw-lite itself currently does (almost) everything via SignalR. But, it'll likely increase in usage. |
Adds links to the Swagger and GraphQL UI in the AppBar, visible only when developer mode is enabled. Fits standard icon-only button patterns by using the IconButton component.