Move onlyBuiltDependencies into pnpm-workspace.yaml#2113
Merged
Conversation
📝 WalkthroughWalkthroughPNPM package manager version bumped from 10.12.3 to 10.24.0 across frontend Dockerfiles and all package.json manifests. The onlyBuiltDependencies configuration moved from frontend/package.json to frontend/pnpm-workspace.yaml. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2111
Apparently
onlyBuiltDependenciesshould only be set in the root of the workspace:We currently have it in our root package.json file, so it was perhaps already effective for all our packages.
However, there's no guarantee that we'll copy the root package.json file into e.g. a docker container when we're building the viewer. We will however definitely copy
pnpm-workspace.yaml, because we need it for version numbers. So, that file is a better place foronlyBuiltDependencies. I needed to update pnpm in order to move it intopnpm-workspace.yaml.