Add parsers for the remaining PT9 interlinear files - #238
Open
jasonleenaylor wants to merge 1 commit into
Open
Conversation
Parse Lexicon.xml, WordAnalyses.xml, and InterlinearSetup.xml into models that mirror the file shapes alongside the existing interlinear parser, as the first slice of the PT9 import pipeline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse Lexicon.xml, WordAnalyses.xml, and InterlinearSetup.xml into models that mirror the file shapes alongside the existing interlinear parser, as the first slice of the PT9 import pipeline:
All parsers are identity-strict and otherwise preserve optional data as written: they throw only on a missing root, duplicate dictionary keys, or entries missing their identity; absent attributes and elements stay absent.
Grow pt9-xml.md into the four-file format reference with a shared conventions section, and add coherent test-data fixtures whose sense ids and lexeme keys resolve against Interlinear_en_MAT.xml.
🤖 Generated with Claude Code
This change is