Skip to content

Keep icon buttons centered while pressed - #214

Draft
alex-rawlings-yyc wants to merge 1 commit into
mainfrom
202-suggestion-add-button-jumps
Draft

Keep icon buttons centered while pressed#214
alex-rawlings-yyc wants to merge 1 commit into
mainfrom
202-suggestion-add-button-jumps

Conversation

@alex-rawlings-yyc

@alex-rawlings-yyc alex-rawlings-yyc commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

The platform button's pressed style is a translate, which overwrites the same custom property a translate utility uses for centering — so the suggestion "+" and the arc split button both jumped mid-click.


This change is Reviewable

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 52e491a0-ac5c-4857-ae54-19c918872b22

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the 202-suggestion-add-button-jumps branch from 20750e9 to 5a44c1b Compare August 11, 2026 18:25
@imnasnainaec

Copy link
Copy Markdown
Contributor

Looks good! But can we put it on ice (i.e., in draft) for a bit? I'm opening a pr on paranext-core for an upstream fix to part of this. If that lands, it will break half of this patch.

@imnasnainaec

Copy link
Copy Markdown
Contributor

paranext/paranext-core#2667 has been merged into main, but did not include a platform-bible-react rebuild, so its fix is not yet available, and we should keep this in draft.

@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the 202-suggestion-add-button-jumps branch from 5a44c1b to 88ad689 Compare August 17, 2026 16:40
The platform button's pressed style is a translate, which overwrites the
same custom property a translate utility uses for centering — so the
suggestion "+" and the arc split button both jumped mid-click.
@alex-rawlings-yyc
alex-rawlings-yyc force-pushed the 202-suggestion-add-button-jumps branch from 88ad689 to 6442334 Compare August 17, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When the + for the suggestions dropdown is clicked, it moves

2 participants