Add free translation input to segment view#114
Conversation
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e25f7f8 to
fb85712
Compare
a77bd89 to
e6dd6f4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
e8d45d2 to
094c16a
Compare
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec partially reviewed 20 files and all commit messages, and made 1 comment.
Reviewable status: 19 of 25 files reviewed, 1 unresolved discussion (waiting on alex-rawlings-yyc).
src/__tests__/components/ContinuousView.test.tsx line 944 at r3 (raw file):
tokenDocOrder={tokenDocOrder} wordTokenByRef={wordTokenByRef} viewOptions={{
Oops, I missed this one, which can be
viewOptions={{ ...allFalseViewOptions, hideInactiveLinkButtons: true }}
ef2f6b7 to
fe1c0ef
Compare
alex-rawlings-yyc
left a comment
There was a problem hiding this comment.
@alex-rawlings-yyc resolved 1 discussion.
Reviewable status: 19 of 26 files reviewed, all discussions resolved (waiting on alex-rawlings-yyc and imnasnainaec).
fe1c0ef to
b224034
Compare
* Add free translation input to segment view * Minor adjustments * Minor adjustment * Reduce test * Refine localized-strings tests * Add all-false ViewOptions test object --------- Co-authored-by: Alex Rawlings <alex.rawlings@wycliffe.ca>
b224034 to
b03628c
Compare
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 6 files and all commit messages, and made 1 comment.
Reviewable status: 25 of 26 files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
src/store/analysisSlice.ts line 174 at r4 (raw file):
(!analysis.freeTranslation || Object.values(analysis.freeTranslation).every((t) => t.trim() === '')) && analysis.literalTranslation === undefined
⛏️
The empty-literal-translation check, instead of === undefined, could mirror the one before it:
(!analysis.literalTranslation ||
Object.values(analysis.literalTranslation).every((t) => t.trim() === ''))
Even better, we could add an isEmptyMultistring util function to call for both.
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec made 1 comment.
Reviewable status: 25 of 26 files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
src/components/SegmentView.tsx line 82 at r4 (raw file):
* passed through to {@link PhraseStripContextValue}; `chapterLabelInVerse` controls this segment's * verse label. */
/** Bundled display toggles; `chapterLabelInVerse` sets the verse label, the rest pass through to {@link PhraseStripContextValue}. */
Code quote:
/**
* Bundled display toggles. `hideInactiveLinkButtons`, `simplifyPhrases`, and `showMorphology` are
* passed through to {@link PhraseStripContextValue}; `chapterLabelInVerse` controls this segment's
* verse label.
*/
imnasnainaec
left a comment
There was a problem hiding this comment.
@imnasnainaec reviewed 4 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on alex-rawlings-yyc).
Devin's review of this PR: https://app.devin.ai/review/sillsdev/interlinearizer-extension/pull/114
This change is
Summary by CodeRabbit
New Features