TT-7300 Mark Verses highlighting & Edit Reference (#314)#322
Open
gtryus wants to merge 2 commits into
Open
Conversation
- Improved segment matching logic in usePlayerLogic for better accuracy. - Updated WSAudioPlayer to support new markVersesTailOpenRef prop for managing verse states. - Enhanced PassageDetailMarkVerses to handle incomplete verse rows and apply region colors dynamically. - Refactored EditReferenceDropdown to manage end verse options and suffix handling more effectively. - Improved MarkVersesTableIsMobile to allow for better interaction and visual feedback based on segment states. - Added tests to ensure correct behavior of new features and UI changes.
gtryus
changed the title
gtryus
changed the title
- Updated existing test to verify that the reference input is not read-only when editable. - Added new test to ensure the reference input remains read-only and disabled when the row lacks timestamps. - Improved interaction feedback for better user experience in mobile view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves Mark Verses on mobile and desktop so the waveform, table, and Edit Reference dialog stay aligned with the wireframes and behave correctly for partial marking, reference editing, and navigation.