Fix LT-22520: Crash when closing Find dialog in Grammar Sketch#882
Open
jtmaxwell3 wants to merge 1 commit into
Open
Fix LT-22520: Crash when closing Find dialog in Grammar Sketch#882jtmaxwell3 wants to merge 1 commit into
jtmaxwell3 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22520. If you try to find something before a sketch has been generated, you get an error. Ideally, we would suppress the Find menu item in this case, but I wasn't sure that I could get that right in all cases. So now if you click on the Find menu item, nothing happens. This isn't perfect, but at least it doesn't crash. This is also pretty uncommon.
This change is