Detect stale FwBuildTasks bootstrap outputs#880
Open
johnml1135 wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a script-level “freshness” check to ensure the bootstrapped FwBuildTasks outputs are rebuilt when stale, avoiding runtime mismatches while keeping the common up-to-date path fast.
Changes:
- Introduces
Test-FwBuildTasksBootstrapRequiredto detect stale/missingFwBuildTasksbootstrap outputs based on timestamps of source and key repo inputs. - Updates bootstrap decision logic to use the freshness check instead of only checking for existence.
- Clarifies
-ForceBuildBuildTaskshelp text.
Contributor
Author
|
Addressed the review notes in
Validation run locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FwBuildTaskswhen the bootstrapped output is older than its source or package/props inputsbuild.ps1to avoid paying for a second MSBuild bootstrap invocation on the common up-to-date path-ForceBuildBuildTaskshelp textOrigin
The change started from build warnings in the main build when
RegFreeprocessing tried to load managed metadata and hit an assembly mismatch in the bootstrappedFwBuildTasksoutput.Root cause
FwBuildTaskswas bootstrapped outside the main traversal build and the existing guard only checked whetherBuildTools/FwBuildTasks/<Configuration>/FwBuildTasks.dllexisted. That meant stale bootstrap outputs could survive package or build-input changes, so old dependency copies could remain inBuildTools/FwBuildTasks/<Configuration>/and produce warnings even though the main build itself was otherwise current.Solution
Add a targeted bootstrap freshness check in
build.ps1that rebuildsFwBuildTaskswhen:Build/Src/FwBuildTaskssource/project/targets input is newer than the bootstrapped DLLThis stays as a cheap script-level preflight instead of always invoking a second MSBuild bootstrap build, which keeps the common up-to-date path faster while still fixing the stale-output case.
Validation
CI: Full local check./build.ps1This change is