Skip to content

Fix LT-11746: Make Preview in Lexicon Edit aware of publication#776

Open
jtmaxwell3 wants to merge 1 commit intomainfrom
LT-11746
Open

Fix LT-11746: Make Preview in Lexicon Edit aware of publication#776
jtmaxwell3 wants to merge 1 commit intomainfrom
LT-11746

Conversation

@jtmaxwell3
Copy link
Collaborator

@jtmaxwell3 jtmaxwell3 commented Mar 20, 2026

This fixes https://jira.sil.org/browse/LT-11746. I refactored IsObjectVisible and GiveSimpleWarning in XhtmlDocView so that their code could be shared by XhtmlRecordDocView.


This change is Reviewable

@github-actions
Copy link

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 12s ⏱️ +23s
4 074 tests ±0  4 003 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 083 runs  ±0  4 012 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit be65cc0. ± Comparison against base commit b6ac397.

@jasonleenaylor
Copy link
Contributor

Src/xWorks/XhtmlDocView.cs line 230 at r1 (raw file):

		}

		internal static bool IsObjectVisible(int hvoTarget, LcmCache cache, PropertyTable propertyTable, out DictionaryConfigurationController.ExclusionReasonCode xrc)

Since we are exposing this to other callers we should probably guard for null cache and propertyTable.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants