Skip to content

Clean up Setup-Developer-Machine.ps1 and set $env:LcmRootDir - #1077

Draft
papeh wants to merge 6 commits into
mainfrom
feature/polish-lcm-clone
Draft

Clean up Setup-Developer-Machine.ps1 and set $env:LcmRootDir#1077
papeh wants to merge 6 commits into
mainfrom
feature/polish-lcm-clone

Conversation

@papeh

@papeh papeh commented Aug 18, 2026

Copy link
Copy Markdown
Contributor
  • Remove the do-nothing environment variable setup region
  • Remove the junction to LCMRepo--it is located by an environment var
  • Check for LibLCM existence in more places before cloning
  • Set $env:LcmRootDir after finding or cloning LibLCM

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • Builds/tests pass locally (or I've run the CI-style build via build.ps1/test.ps1 or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.
  • All comments from an AI code reviewer have been considered (such as Devin)

This change is Reviewable

papeh added 3 commits August 18, 2026 11:32
* Remove the junction to LCMRepo--it is located by an environment var
* Check for LibLCM existence in more places before cloning
* Set $env:LcmRootDir after finding or cloning LibLCM
* Persist LcmRootDir
* Set FEEDBACK=off to prevent developers from sending prod analytics
@papeh
papeh force-pushed the feature/polish-lcm-clone branch from 637cd7b to 5ae26be Compare August 18, 2026 16:34
@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files      1 suites   10m 58s ⏱️
5 778 tests 5 697 ✅ 81 💤 0 ❌
5 787 runs  5 706 ✅ 81 💤 0 ❌

Results for commit aa76301.

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.06%. Comparing base (0ab90ff) to head (aa76301).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1077       +/-   ##
=========================================
+ Coverage      0   38.06%   +38.06%     
=========================================
  Files         0     1499     +1499     
  Lines         0   350154   +350154     
  Branches      0    40241    +40241     
=========================================
+ Hits          0   133299   +133299     
- Misses        0   187573   +187573     
- Partials      0    29282    +29282     

see 1499 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

papeh added 3 commits August 18, 2026 11:51
* Move PATH refresh to the PATH region
* Remove empty Verification region
* Set global env var only if it exists and points to a folder
* Test $localizationsPath only if not $isWorktree
* Update Setup-InstallerBuild and MD to recognize $env:LcmRootDir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants