Fix LT-22605: Add ability to limit Hermit Crab parses - #1071
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
==========================================
+ Coverage 38.04% 38.07% +0.02%
==========================================
Files 1499 1499
Lines 350127 350154 +27
Branches 40239 40241 +2
==========================================
+ Hits 133215 133323 +108
+ Misses 187625 187550 -75
+ Partials 29287 29281 -6
🚀 New features to boost your workflow:
|
|
Is this if intended to check |
|
@thejambi: Good catch! Thanks! |
|
Should we add a |
thejambi
left a comment
There was a problem hiding this comment.
@thejambi reviewed 4 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on jtmaxwell3).
thejambi
left a comment
There was a problem hiding this comment.
Changes look good!
@thejambi reviewed 5 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on jtmaxwell3).
thejambi
left a comment
There was a problem hiding this comment.
@thejambi resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on jtmaxwell3).
This fixes https://jira.sil.org/browse/LT-22605. It adds a MaxAlternatives parameter to the Parser Parameters dialog and uses it to set MaxAlternatives in a new version of Hermit Crab.
This change is