Skip to content

Add tests for LT-22576 - #1052

Draft
imnasnainaec wants to merge 2 commits into
mainfrom
LT-22576-tests
Draft

Add tests for LT-22576#1052
imnasnainaec wants to merge 2 commits into
mainfrom
LT-22576-tests

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

Quick Summary

Tests requested by #1051 author, generated by Claude.

Devin review: https://app.devin.ai/review/sillsdev/FieldWorks/pull/1052

CI-ready checklist

  • Commit messages follow .github/commit-guidelines.md (subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).
  • No whitespace warnings locally:
    git fetch origin
    git log --check --pretty=format:"---% h% s" origin/<base>..
    git diff --check --cached
  • Builds/tests pass locally (or I've run the CI-style build via Bash script or MSBuild).
  • If this is core-developer AI-assisted work, I followed Docs/workflows/ai-pr-workflow.md and ran pr-preflight or the equivalent branch-readiness review before requesting review.
  • For any Src/** folders touched, corresponding AGENTS.md files are updated or explicitly confirmed still accurate.

This change is Reviewable

@imnasnainaec
imnasnainaec requested a review from aror92 August 7, 2026 19:34
Base automatically changed from LT-22576 to main August 7, 2026 19:37
@github-actions

This comment has been minimized.

Cover IsFeatureBasedNCNameUserDefined and
RuleFormulaSlice.OnDisplayContextSetFeatures for user-named,
auto-generated, unnamed, segment-based, iteration-wrapped, and
empty-selection contexts.

The test control overrides GetCmObject, the extension point
concrete rule controls already implement, so the
selection-to-context logic under test is the production code.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Change-Id: I5eb3da581ac087934f99e88e71cd31518ea69bce
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ± 0      1 suites  ±0   7m 50s ⏱️ - 3m 43s
5 796 tests +35  5 715 ✅ +35  81 💤 ±0  0 ❌ ±0 
5 805 runs  +35  5 724 ✅ +35  81 💤 ±0  0 ❌ ±0 

Results for commit dec7d52. ± Comparison against base commit 3c9a28a.

This pull request removes 10 and adds 45 tests. Note that renamed tests count towards both.
LexEdDllTests.EntrySequenceChooserCommandKeepOwnerActiveWhenHidingTests ‑ AddComplexFormChooserCommand_OptsIn
LexEdDllTests.EntrySequenceChooserCommandKeepOwnerActiveWhenHidingTests ‑ AddPrimaryLexemeChooserCommand_OptsIn
SIL.FieldWorks.Common.Framework.DetailControls.ChooserCommandKeepOwnerActiveWhenHidingTests ‑ MakeInflAffixEntryChooserCommand_OptsIn
SIL.FieldWorks.Common.Framework.DetailControls.ChooserCommandKeepOwnerActiveWhenHidingTests ‑ MakeInflAffixSlotChooserCommand_DoesNotOptIn
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RefreshDisplayNeedsReconstructTests ‑ NotifyDataAccessSemanticsChanged_DefersUntilVisible
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RefreshDisplayNeedsReconstructTests ‑ NotifyDataAccessSemanticsChanged_Reconstructs_WhenRootBoxDoesNotNeedReconstruct
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RefreshDisplayNeedsReconstructTests ‑ RefreshDisplay_Reconstructs_WhenRootBoxNeedsReconstruct
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RefreshDisplayNeedsReconstructTests ‑ RefreshDisplay_SkipsReconstruct_WhenRootBoxDoesNotNeedReconstruct
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RefreshDisplayNeedsReconstructTests ‑ SetRootBoxDataAccessAndRefresh_Reconstructs_WhenSwapChangesDisplaySemantics
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RefreshDisplayNeedsReconstructTests ‑ SetRootBoxDataAccess_DoesNotReconstruct_WhenSwapIsCheap
LexEdDllTests.EntrySequenceChooserCommandKeepOwnerActiveWhenHidingTests ‑ AddComplexFormChooserCommand_KeepsOwnerActive
LexEdDllTests.EntrySequenceChooserCommandKeepOwnerActiveWhenHidingTests ‑ AddPrimaryLexemeChooserCommand_KeepsOwnerActive
LexTextControlsTests.LiftExportTests ‑ LiftExportRanges_CustomListRangeIdWithAmpersandIsEscapedExactlyOnce
LexTextControlsTests.LiftExportTests ‑ LiftExportRanges_CustomListRangeIdWithQuoteIsEscapedForAnAttribute
SIL.FieldWorks.Common.Framework.DetailControls.ChooserCommandKeepOwnerActiveWhenHidingTests ‑ MakeInflAffixEntryChooserCommand_KeepsOwnerActive
SIL.FieldWorks.Common.Framework.DetailControls.ChooserCommandKeepOwnerActiveWhenHidingTests ‑ MakeInflAffixSlotChooserCommand_KeepsOwnerActive
SIL.FieldWorks.Common.FwUtils.UIModeGatesTests ‑ IsSwitchingEnabled_FailsClosedForUnsetAndNegativeValues("   ")
SIL.FieldWorks.Common.FwUtils.UIModeGatesTests ‑ IsSwitchingEnabled_FailsClosedForUnsetAndNegativeValues(" off ")
SIL.FieldWorks.Common.FwUtils.UIModeGatesTests ‑ IsSwitchingEnabled_FailsClosedForUnsetAndNegativeValues("")
SIL.FieldWorks.Common.FwUtils.UIModeGatesTests ‑ IsSwitchingEnabled_FailsClosedForUnsetAndNegativeValues("0")
…

♻️ This comment has been updated with latest results.

@codecov-commenter

codecov-commenter commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.12%. Comparing base (3c9a28a) to head (dec7d52).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
+ Coverage   38.02%   38.12%   +0.09%     
==========================================
  Files        1499     1499              
  Lines      349910   350154     +244     
  Branches    40226    40241      +15     
==========================================
+ Hits       133055   133484     +429     
+ Misses     187577   187402     -175     
+ Partials    29278    29268      -10     
Files with missing lines Coverage Δ
Src/LexText/Morphology/RuleFormulaControl.cs 14.37% <ø> (+14.37%) ⬆️
Src/LexText/Morphology/RuleFormulaSlice.cs 26.78% <100.00%> (+26.78%) ⬆️

... and 159 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Change-Id: I285252c9aee70dbce1a349d03b001fec1feec4a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants