Add tests for LT-22576 - #1052
Draft
imnasnainaec wants to merge 2 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Cover IsFeatureBasedNCNameUserDefined and RuleFormulaSlice.OnDisplayContextSetFeatures for user-named, auto-generated, unnamed, segment-based, iteration-wrapped, and empty-selection contexts. The test control overrides GetCmObject, the extension point concrete rule controls already implement, so the selection-to-context logic under test is the production code. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I5eb3da581ac087934f99e88e71cd31518ea69bce
NUnit Tests 1 files ± 0 1 suites ±0 7m 50s ⏱️ - 3m 43s Results for commit dec7d52. ± Comparison against base commit 3c9a28a. This pull request removes 10 and adds 45 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1052 +/- ##
==========================================
+ Coverage 38.02% 38.12% +0.09%
==========================================
Files 1499 1499
Lines 349910 350154 +244
Branches 40226 40241 +15
==========================================
+ Hits 133055 133484 +429
+ Misses 187577 187402 -175
+ Partials 29278 29268 -10
🚀 New features to boost your workflow:
|
Change-Id: I285252c9aee70dbce1a349d03b001fec1feec4a4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Summary
Tests requested by #1051 author, generated by Claude.
Devin review: https://app.devin.ai/review/sillsdev/FieldWorks/pull/1052
CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).If this is core-developer AI-assisted work, I followedDocs/workflows/ai-pr-workflow.mdand ranpr-preflightor the equivalent branch-readiness review before requesting review.Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.This change is