fix(types,fonts): Base "ex' unit on proper metrics and add "cap" unit #2320
+91
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Omikhleia
added
bug
Omikhleia
force-pushed
the
fix-correct-ex-unit
branch
3 times, most recently
from
8c6645a to
37c136c
Compare
The "cap" unit is proposed in CSS4 Draft and makes sense for cap-height font adjustement. Both "ex" and "cap" shall be based on font metrics when available, and only measure a character as a fallback heuristic. Some fonts may not have the necessary Latin characters, in which case we shall resorti to a decent fallback (as per CSS recommendations).
Omikhleia
force-pushed
the
fix-correct-ex-unit
branch
from
37c136c to
01eb1e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "cap" unit is proposed in CSS4 Draft and makes sense for cap-height font adjustement.
Both "ex" and "cap" shall be based on font metrics when available, and only measure a character as a fallback heuristic.
Some fonts may not have the necessary Latin characters, in which case we shall resorti to a decent fallback (as per CSS recommendations).
Closes #2317
Note 1: Obviously this only takes all its value with PR #2319
Note 2: Some fonts have small differences between the sxHeight metric and the measured height of a lowercase “x”.
As a result, several regression tests (e.g., those using Libertinus Serif) will fail.
Minor variations in output are also to be expected.
But if I have interpreted the issue correctly, this represents better typography — and I am weighting for it.