Add java25 checks and unit test min to java17 - #1244
Open
loosebazooka wants to merge 1 commit into
Open
Conversation
loosebazooka
force-pushed
the
add-java-25-stuff
branch
3 times, most recently
from
July 27, 2026 14:01
797036e to
3fe4fac
Compare
vlsi
previously approved these changes
Jul 27, 2026
loosebazooka
force-pushed
the
add-java-25-stuff
branch
from
July 27, 2026 19:45
3fe4fac to
d505f6c
Compare
loosebazooka
force-pushed
the
add-java-25-stuff
branch
from
August 11, 2026 19:01
d505f6c to
99e0c06
Compare
aaronlew02
previously approved these changes
Aug 11, 2026
loosebazooka
changed the title
- Set testCompile tasks to target java17 - Also compile sigstore-testkit module with java17 - Upgrade mock-oauth2-server to 5.0.2 - Update google java format to 1.35.0 Signed-off-by: Appu <appu@google.com>
loosebazooka
force-pushed
the
add-java-25-stuff
branch
from
August 21, 2026 20:31
99e0c06 to
028d751
Compare
vlsi
approved these changes
Aug 22, 2026
vlsi
left a comment
vlsi
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. A single property instead of replicating 17 would be nice as well
| release.set(buildParameters.targetJavaVersion) | ||
| plugins.withId("java") { | ||
| tasks.named<JavaCompile>("compileTestJava") { | ||
| options.release.set(17) |
Collaborator
There was a problem hiding this comment.
It might make sense to create a property for testTargetJdk like we have for the main code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release Note
Documentation