Group all peer logic into a single struct#563
Open
AgeManning wants to merge 2 commits intolighthouse-gossipsubfrom
Open
Group all peer logic into a single struct#563AgeManning wants to merge 2 commits intolighthouse-gossipsubfrom
AgeManning wants to merge 2 commits intolighthouse-gossipsubfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have grouped all the peer connection mappings into a single struct with strict mutability rules. This makes it significantly easier to reason about how these mappings change relative to each other. It should be very clear if any of these mappings go out of sync now.
This also simplified a bit of the code in the behaviour, however there was a cost of doing this change, which involved adding a few clones of some peer lists as we can no longer hold multiple mutable references of the mappings as they are grouped into this new struct. I think the trade-off is worth it to simplify the logical complexity.