Gloas relax epoch aligned checkpoint state requirements#9091
Closed
eserilev wants to merge 8 commits intosigp:unstablefrom
Closed
Gloas relax epoch aligned checkpoint state requirements#9091eserilev wants to merge 8 commits intosigp:unstablefrom
eserilev wants to merge 8 commits intosigp:unstablefrom
Conversation
…' of https://github.com/eserilev/lighthouse into gloas-relax-epoch-aligned-checkpoint-state-requirements
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
eserilev
added
ready-for-review
eserilev
commented
Apr 6, 2026
Comment on lines
+1905
to
+1907
| if summary.slot == summary.latest_block_slot { | ||
| return Ok(StatePayloadStatus::Pending); | ||
| } |
Member
Author
There was a problem hiding this comment.
im actually not 100% sure about this, maybe we do need to check the previous state summary first?
Member
Author
|
Closing in favour of michaels db PR plus whatever spec changes we make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-gloas checkpoint sync states are always the post block state. If theres a skipped slot at an epoch boundary, we'll receive a non-epoch aligned state from the checkpointz server.
Example: slot n is epoch aligned and is skipped. Checkpoint server will serve the post block state for slot n - 1. We cant advance the state to slot n until we process the payload for slot n - 1 (if it exists/is canonical)
This PR loosens the requirement that a checkpoint state must be epoch aligned. This requirement is only loosened for a gloas checkpoint state, subsequent finalized states must be epoch aligned.
Note that the test introduced in this PR doesn't actually do anything until #8998 is merged. I've tested it on top of #8998 and it seems to be working.
When checkpoint syncing, range sync starts at the same epoch as the checkpoint state. So we just need to make sure
filter_chain_segmentdoesn't drop the envelope for the checkpoint block (the checkpoint block and columns were already imported) and everything should work I think?EDIT: I experimented with checkpoint sync and I think the easiest thing would be to make sure checkpointz server is extended to support
GET eth/v1/beacon/payload_envelopes/{block_id}. This way we fetch the payload (if it exists) and advance the state to the epoch boundary before we hit range sync.