Skip to content

Use spec constants for PTC thresholds in fork choice#9088

Merged
mergify[bot] merged 1 commit intosigp:unstablefrom
dapplion:dapplion/fc-spec-constants
Apr 4, 2026
Merged

Use spec constants for PTC thresholds in fork choice#9088
mergify[bot] merged 1 commit intosigp:unstablefrom
dapplion:dapplion/fc-spec-constants

Conversation

@dapplion
Copy link
Copy Markdown
Collaborator

@dapplion dapplion commented Apr 4, 2026

Follow-up from #9025. The is_payload_timely and is_payload_data_available functions were using inline ptc_size() / 2 instead of the spec constant functions. This adds data_availability_timely_threshold() to EthSpec and uses both it and the existing payload_timely_threshold() in proto_array.

@dapplion dapplion added gloas ready-for-review The code is ready for review labels Apr 4, 2026
@eserilev eserilev added the ready-for-merge This PR is ready to merge. label Apr 4, 2026
@eserilev
Copy link
Copy Markdown
Member

eserilev commented Apr 4, 2026

@mergify requeue

@eserilev
Copy link
Copy Markdown
Member

eserilev commented Apr 4, 2026

@mergify dequeue

@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 4, 2026

Merge Queue Status

  • 🟠 Waiting for queue conditions
  • ⏳ Enter queue
  • ⏳ Run checks
  • ⏳ Merge
Required conditions to enter a queue
  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of [📌 queue -> configuration change requirements]:
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of [🔀 queue conditions]:
    • all of [📌 queue conditions of queue rule default]:
      • #approved-reviews-by >= 1
      • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • check-success=license/cla
      • check-success=target-branch-check
      • label!=do-not-merge

@mergify mergify Bot added the queued label Apr 4, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 4, 2026

Merge Queue Status

This pull request spent 34 minutes in the queue, including 28 minutes 3 seconds running CI.

Required conditions to merge

mergify Bot added a commit that referenced this pull request Apr 4, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Apr 4, 2026

requeue

☑️ This pull request is already queued

@mergify mergify Bot merged commit 7559dd2 into sigp:unstable Apr 4, 2026
38 checks passed
@mergify mergify Bot removed the queued label Apr 4, 2026
@dapplion dapplion deleted the dapplion/fc-spec-constants branch April 5, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gloas ready-for-merge This PR is ready to merge. ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants