feat: add more scheduling options for process runner#9862
feat: add more scheduling options for process runner#9862talos-bot merged 1 commit intosiderolabs:mainfrom
Conversation
dsseng
left a comment
dsseng
left a comment
There was a problem hiding this comment.
Unsure how we test this. Perhaps running a unit test on the host won't work (or maybe it'll be okay if we lower priorities or set idle scheduling class), and an integration test would require exposing unneeded APIs
if we can do a test, that'd be cool. we could use this for the |
|
Hm, but then we'll need to get those parameters from Talos to test. In case of xfs_scrub I just waited for it to run and inspected the process with |
dashboard runs, so we can do an integration test? |
yeh we could run those tools from a privileged pod in test, we already have helpers for these |
I guess we could simply read from |
|
I guess nice and maybe scheduling policy could be received using procfs, let's see. Didn't find anything about IO priorities so they're likely fetched using a syscall. But if we can run commands in a privileged pods that could work as well. |
|
I don't think giving dashboard some weird scheduling policy would be great. Idle can make it not informative when system has something to do (it won't be scheduled) while RT-like would increase resource usage by dashboard and raise its priority too much |
Probably not totally idle, but de-prioritizing in favor of anything else I guess might make sense |
|
Well, out of 6 scheduling policies default perhaps shouldn't be changed. Offsetting priority (nice) would be good |
dsseng
force-pushed
the
process-sched-opts
branch
from
4840b76 to
aede8a5
Compare
smira
left a comment
smira
left a comment
There was a problem hiding this comment.
should we de-prioritize dashboard?
| } | ||
|
|
||
| func (suite *ProcessSuite) TestPriority() { | ||
| pidFile := filepath.Join(suite.tmpDir, "talos-test-pid-prio") |
There was a problem hiding this comment.
do we need to t.Skip() this is os.Getuid() != 0? (to make go test ./... pass without buildkit?)
There was a problem hiding this comment.
go test -v ./internal/app/machined/pkg/system/runner/process works for me, it's how I developed this. If we have nice < 17 we can drop nice to 17 (generally) without caps or root
By how many? Not really sure, as it must still be responsive even under load, so just increase niceness by some points |
I'd say it's the last thing that should be responsive (when compared to any other system component). |
|
10 should do fine then. 0 - normal, -19 - max, 20 - least prioritized. Should I do it here as well? |
This commit adds runner options for priority, IO priority, scheduling policy. It also cleans up previously developed code for capabilities. This is useful to launch background tasks such as xfs_scrub to not reduce system performance. We set nice 10 for dashboard so that it gives priority to more important system services. Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
dsseng
force-pushed
the
process-sched-opts
branch
from
aede8a5 to
9081506
Compare
|
/m |
4 participants
This allows us to run low-priority background tasks like xfs_scrub only while idle.
Example usage in #9848