This repository was archived by the owner on Dec 12, 2023. It is now read-only.
Make mandatory session properties immutable#54
Open
interpretor wants to merge 8 commits intosidebase:mainfrom
Open
Make mandatory session properties immutable#54interpretor wants to merge 8 commits intosidebase:mainfrom
interpretor wants to merge 8 commits intosidebase:mainfrom
Conversation
BracketJohn
suggested changes
Dec 5, 2022
BracketJohn
reviewed
Dec 5, 2022
| ip?: string; | ||
| readonly id: string; | ||
| readonly createdAt: Date; | ||
| readonly ip?: string; |
Contributor
There was a problem hiding this comment.
and, sorry to kind of push this in here, but as we're already working on the Session interface: Would you consider adapting the h3 event context as done here:
https://github.com/sidebase/nuxt-prisma/blob/b1ffd717cf1061215498fa8e9b90ce62cac8b494/src/runtime/server/middleware/prisma.ts#L7-L11
whuile you're add it? This way, typing for the end-user should improve when they access event.context.session
Contributor
Author
There was a problem hiding this comment.
Added it, but somehow the types aren't available when packed and imported as module in a project. Any suggestions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2.
Checklist:
#)Attach a session object to the event context with mandatory immutable properties
id,createdAtandip.When the user wants to reassign those properties, an error is thrown. This is better than just doing nothing, because the user knows that he did something wrong in saving properties to the session in the event context.