fix authState getting wiped on page reload on static websites#712
Closed
Vijayabhaskar96 wants to merge 5 commits intosidebase:mainfrom
Closed
fix authState getting wiped on page reload on static websites#712Vijayabhaskar96 wants to merge 5 commits intosidebase:mainfrom
Vijayabhaskar96 wants to merge 5 commits intosidebase:mainfrom
Conversation
Member
|
Hi @Vijayabhaskar96 👋 The tests are sadly failing and this PR has some merge conflicts. When you have a chance to address these, feel free to ping me again and I will review the changes ❤️ |
Contributor
Author
Member
|
@Vijayabhaskar96, so this PR is now outdated right? I would then close this PR just so we focus on the correct one 😊 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#551
This issue occurs because
data(data fromgetSession()) is not stored in the browser, which is not a problem in SSR with server because the server takes care of it, but on a statically generated website, thisdatais lost along withrawTokeneven if the token is stored in the browser cookies if you refresh the webpage.❓ Type of change
📚 Description
This PR stores the retrieved data from
getSession()and stores it in the browser cookieauth:sessionCookieand reloads thedataandrawTokenback on the client side if they'reundefined.This PR fixes the data issue, but you still need to set the
prerender:falsefor middleware protected routes in routeRules so that client-side middleware is forced to run and load the states.📝 Checklist