fix(security): remove unused semantic-release, pin serverless's tar >…#740
Open
sid88in wants to merge 1 commit into
Open
fix(security): remove unused semantic-release, pin serverless's tar >…#740sid88in wants to merge 1 commit into
sid88in wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis PR removes the ChangesDependency Updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…=7.5.16 The tar flagged by Dependabot alert 250 (CVE-2026-53655 / GHSA-vmf3-w455-68vh, tar <= 7.5.15) is bundled inside the npm package, reached via semantic-release -> @semantic-release/npm -> npm. npm overrides cannot rewrite bundled dependencies, so the scoped override from #739 cannot reach it. semantic-release is unused: no .releaserc, no release key, not referenced in any workflow or npm script. Releases are tag-driven via release.yml. Removing it drops npm and its bundled tar (-399 packages). Also raises #739's override floor from ^7.5.8 to ^7.5.16, since ^7.5.8 permits 7.5.15 -- the version this advisory affects. Resolves to tar@7.5.19 either way. Single tar@7.5.19 remains; no tar advisories. build, lint and 362 tests pass. Refs: GHSA-vmf3-w455-68vh
7fdd351 to
c6a2dc0
Compare
AlexHladin
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(security): remove unused
semantic-release, raise tar override floor to>=7.5.16Addresses Dependabot alert 250 (
decompress-style bundled-dependency case fortar).Builds on top of #739 and #738.
Summary
Two changes to
package.json:semantic-releasefromdevDependencies— it is entirely unused, and it is the only path to the vulnerabletarbundled inside thenpmpackage.overrides.serverless.tarfloor from^7.5.8(set in fix(security): force serverless's tar to >=7.5.8 (CVE-2026-26960) #739) to^7.5.16.The advisory
CVE-2026-53655 / GHSA-vmf3-w455-68vh — Moderate (6.9). Affected
tar <= 7.5.15; patched7.5.16. Tagged Development dependency.node-tar applies a PAX
size=record to intermediary GNU long-name (L) / long-link (K) headers. Per POSIX pax, a PAX extended header describes the next file entry, not the intervening extension headers. Letting the override apply to anL/Kheader desynchronizes node-tar's stream cursor relative to GNU tar, libarchive/bsdtar, and Pythontarfile.The result is a tar parser interpretation differential (CWE-436): one crafted archive yields a different member list under node-tar than under reference tools, so a file can be hidden from a scanner that parses with one library while still landing on disk via another.
Why #739's override cannot fix this
After #739, the tree still contains two
tarcopies:7.5.19node_modules/tarserverless— already overridden by #7397.5.15node_modules/npm/node_modules/tarnpmThe remaining copy is reached via:
taris one of npm's 65bundleDependencies— it ships pre-installed inside npm's own tarball. npmoverridescannot rewrite bundled dependencies. Verified empirically: adding a global"overrides": { "tar": "^7.5.16" }leavesnode_modules/npm/node_modules/tarat7.5.15andnpm auditstill reports GHSA-vmf3-w455-68vh. An override only affects the hoisted top-level copy.So the vulnerable
tarcan only be removed by removing whatever pullsnpmin.Why removing
semantic-releaseis the right fixsemantic-releaseis not used by this repository:.releaserc/.releaserc.json/release.config.js."release"key inpackage.json.Releases are tag-driven via
.github/workflows/release.yml: pushing av*.*.*tag runs test/lint/build, sets the version from the tag name, and publishes.semantic-releaseis leftover from an earlier release approach — the same phantom-dependency pattern as@serverless/utilsin #738.Removing it drops
npmand its bundledtar(−399 packages).Why also raise the override floor
#739 set
^7.5.8, which permits7.5.15— precisely the version this advisory affects. npm resolves to the highest satisfying version (7.5.19) and the lockfile pins it, so this is not exploitable today; raising the floor to^7.5.16simply makes the intent explicit and prevents a future resolution into the vulnerable range. Resolves totar@7.5.19either way.Result
Verified against current
master(b48496b, i.e. with #738 and #739 merged):tarremains:7.5.19. Notarfindings innpm audit.tarwas never in the production tree, so plugin consumers were never exposed; this clears the dev-tree alert.npm run build,npm run lint(0 errors),npm run test(362 passing) all green.husky/lint-stagedunaffected — thepreparehook still works.npm audit --omit=devnow reports 0 vulnerabilities.To apply
Notes
semantic-releaseprunes ~399 transitive packages. No runtime dependency is touched;package.jsonchanges by two lines.semantic-releaseis ever wanted back, reintroduce it with real configuration wired into the release workflow, and choose a line whose@semantic-release/npmbundlesnpmwithtar >= 7.5.16.npm auditfindings (decompress,tmp,js-yaml, …) are dev-only advisories fromserverless/@serverless/test, tracked separately.