Remove B2FileList's unused file cache#28
Open
Katharine wants to merge 1 commit intosibblegp:masterfrom
Open
Conversation
|
This solves #31 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
B2FileListmaintains a cache of files in a bucket, and updates it on some (but not all) mutation operations. However, the cache is never read.This PR removes the cache, primarily because it isn't used. As motivation, in its current implementation, maintaining the cache is extraordinarily expensive. In particular, every time a file is uploaded, the entire bucket is listed again. This is expensive in both requests and bandwidth, especially when uploading a batch of many files (when you will make O(n^2) requests to upload n files). Many (most?) B2 use cases don't need a complete bucket listing at all.
The behaviour of the cache could potentially be improved instead of removing it, but given it is entirely unused, doing so didn't seem worth the effort here.