Code hardening to deal with null/undefined files object#69
Open
rainabba wants to merge 2 commits intoshuyu:masterfrom
Open
Code hardening to deal with null/undefined files object#69rainabba wants to merge 2 commits intoshuyu:masterfrom
rainabba wants to merge 2 commits intoshuyu:masterfrom
Conversation
If the files object is set to null/undefined, the call to .map throws an unhanded exception, but it shouldn't be called anyway if files isn't a valid array. This patch accounts for that possibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of a form reset, I had set my bound files object to be null. This code assumed files to be a valid array (which would then have .map() on it) so I added logic to short-circuit onFileChanged() if files is null/undefined or doesn't have .map on it.