[1/2] fix: keep a merge field's resolved text as text when it starts with digits - #152
Open
dazzatronus wants to merge 1 commit into
Open
[1/2] fix: keep a merge field's resolved text as text when it starts with digits#152dazzatronus wants to merge 1 commit into
dazzatronus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A merge field whose resolved text starts with a digit became a number:
"03 image of a cat"resolved to3, and the property lost its text entirely. Any value that looks numeric at the front is affected, including"007"and"0xffffff".resolveToNumberusedparseFloat, which accepts a numeric prefix. Now a whole-string parse, so text stays text unless the entire value is a number.This moves the SDK closer to the render backend without reaching it. The backend decides the resulting type from the type of
replace; the SDK infers it from the property name and the resolved text, so a numeric-looking string can still differ between preview and render. Closing that gap needs a breaking change to the public merge field typings and is tracked separately.Verify:
npx jest tests/merge-field-numeric-resolution.test.ts— a bare number, a numeric prefix, an empty resolution, a non-template input.Risk: a field that previously resolved to a number now stays a string unless the whole value is numeric. Templates relying on the prefix behaviour change shape.