docs: fix Code Push casing and Fluter typo regression in FAQ#584
Merged
Conversation
PR #581 (a typo fix based on pre-#579 content) and PR #579 (proper noun capitalization) both touched this same line. Merge ordering left the line with the pre-#579 casing and the pre-#581 typo, an invisible regression since it wasn't part of either PR's diff by the time both were merged. Restores both fixes.
tomarra
added a commit
that referenced
this pull request
Jul 2, 2026
Bumps both custom rules from warning to error severity and flips fail_on_error to true in CI, so they now actually gate merges instead of just annotating PRs. Vale.Terms (proper-noun capitalization) is explicitly downgraded to warning via `Vale.Terms = warning`, staying non-blocking. It doesn't respect code-fence exclusion the way our custom scope:text rules do, and a TokenIgnores pattern matching one occurrence of a shell command (e.g. `shorebird release android`) intermittently fails to suppress a second, identical occurrence elsewhere in the same file - confirmed with minimal reproductions, not a config mistake. Findings are still reported, just don't block. Shorebird.SecondPerson stays at warning too, since that guideline's content work hasn't happened yet. IMPORTANT: this branch's own CI will fail until #583 (heading sentence-case fixes) merges - this branch still has the original Title Case headings. Do not merge this PR before #583. Verified the full combination (this branch + main + #583 + #584) passes cleanly with fail_on_error: true.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
A small but real regression on
mainright now: #581 (a typo fix, "Fluter" → "Flutter") was branched from content that predated #579 (proper-noun capitalization). Both PRs touched the same line infaq.mdx. By the time both merged, the line had reverted to the pre-#579 casing ("code push" lowercase) and the pre-#581 typo ("Fluter") — invisible in either PR's own diff, since it happened via merge ordering, not either PR's actual changes.Found this while checking whether the content-guideline lint checks could be made blocking — it would have silently broken that effort, since
Vale.Terms(proper-noun capitalization) runs aterrorseverity and this line's lowercase "code push" would show up as an unexplained new failure with no obvious cause in the diff.Test plan
npm run buildsucceeds