fix: component library audit deps#1061
Open
Alastair Fraser (alastair-simon) wants to merge 3 commits intomainfrom
Open
fix: component library audit deps#1061Alastair Fraser (alastair-simon) wants to merge 3 commits intomainfrom
Alastair Fraser (alastair-simon) wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Alastair Fraser (alastair-simon)
force-pushed
the
fix/component-library-audit-deps
branch
from
2199aae to
da584a8
Compare
Alastair Fraser (alastair-simon)
marked this pull request as ready for review
Jannis Leifeld (jleifeld)
approved these changes
Mar 12, 2026
@shopware-ag/meteor-admin-sdk
@shopware-ag/meteor-component-library
@shopware-ag/meteor-icon-kit
@shopware-ag/meteor-prettier-config
@shopware-ag/stylelint-plugin-meteor
@shopware-ag/meteor-tokens
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Moved @testing-library/vue, @testing-library/jest-dom, and @storybook/addon-a11y from dependencies to devDependencies in @shopware-ag/meteor-component-library.
Why?
They are only used for tests and Storybook. Having them in dependencies meant consumers got them, which triggered high-severity npm audit findings. Moving them to devDependencies removes that chain for consumers while keeping tests and Storybook working in the repo.
How?
I have moved these packages into devDependencies from dependencies. Published packages only install dependencies, so consumers no longer get this tooling or its vulnerable transitive deps.