-
Notifications
You must be signed in to change notification settings - Fork 306
Fix broen links - issue 2206 #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -23,7 +23,7 @@ | |||||
|
|
||||||
| ## Redirects | ||||||
|
|
||||||
| Redirects from old URLs to new ones are managed via the [`.gitbook.yaml`](./.gitbook.yaml) file. This ensures continued access to content after pages are renamed or relocated. | ||||||
| Redirects from old URLs to new ones are managed via the [`.gitbook.yaml`](https://github.com/shopware/docs/blob/main/.gitbook.yaml) file. This ensures continued access to content after pages are renamed or relocated. | ||||||
|
|
||||||
| When deleting, moving or renaming pages, compare your branch against `main`, identify the moved files, and add corresponding redirects to `.gitbook.yaml` following the existing patterns. | ||||||
|
|
||||||
|
|
@@ -34,19 +34,19 @@ | |||||
|
|
||||||
| ## Workflows | ||||||
|
|
||||||
| They are defined in the [`.github/workflows`](./.github/workflows/) folder and help the DX team to maintain the documentation. The workflows are triggered by events like `push`, `pull_request`, `schedule` and `workflow_dispatch`. The workflows are used to build, test, and deploy the documentation. If a PR pipeline fails, the PR will be marked as failed, and it won't be possible to merge it. In this case, check the below-mentioned workflows to see what went wrong and where to fix it. | ||||||
| They are defined in the [`.github/workflows`](https://github.com/shopware/docs/tree/main/.github/workflows) folder and help the DX team to maintain the documentation. The workflows are triggered by events like `push`, `pull_request`, `schedule` and `workflow_dispatch`. The workflows are used to build, test, and deploy the documentation. If a PR pipeline fails, the PR will be marked as failed, and it won't be possible to merge it. In this case, check the below-mentioned workflows to see what went wrong and where to fix it. | ||||||
|
Check warning on line 37 in README.md
|
||||||
|
|
||||||
| ### Grammar and language check | ||||||
|
|
||||||
| All changed content is checked with Reviewdog for grammar and language. The configuration for Reviewdog can be found in [`.reviewdog.yml`](./.github/workflows/reviewdog.yml). It will create warnings in the pull request if the language or grammar is not correct. A more in-depth explanation can be found in [Language and Grammar](./resources/guidelines/documentation-guidelines/03-language-and-grammar.md) section. | ||||||
| All changed content is checked with Reviewdog for grammar and language. The configuration for Reviewdog can be found in [`.reviewdog.yml`](https://github.com/shopware/docs/blob/main/.github/workflows/reviewdog.yml). It will create warnings in the pull request if the language or grammar is not correct. A more in-depth explanation can be found in [Language and Grammar](./resources/guidelines/documentation-guidelines/03-language-and-grammar.md) section. | ||||||
|
|
||||||
| ### Markdown check | ||||||
|
|
||||||
| The markdown files are checked with [markdown-lint](https://github.com/avto-dev/markdown-lint) to identify issues such as formatting errors, style inconsistencies, etc. By doing so, it facilitates the creation of well-structured and consistent Markdown documents.. The configuration for markdown-lint can be found in [`markdown-style-check.yml`](./.github/workflows/markdown-style-check.yml). | ||||||
| The markdown files are checked with [markdown-lint](https://github.com/avto-dev/markdown-lint) to identify issues such as formatting errors, style inconsistencies, etc. By doing so, it facilitates the creation of well-structured and consistent Markdown documents.. The configuration for markdown-lint can be found in [`markdown-style-check.yml`](https://github.com/shopware/docs/blob/main/.github/workflows/markdown-style-check.yml). | ||||||
|
Check warning on line 45 in README.md
|
||||||
|
||||||
|
|
||||||
| ### Spellcheck | ||||||
|
|
||||||
| The markdown files are checked with [py-spelling](https://facelessuser.github.io/pyspelling/) to rectify spelling errors. The configuration for py-spelling can be found in [`.spellcheck.yml`](./.spellcheck.yml). | ||||||
| The markdown files are checked with [py-spelling](https://facelessuser.github.io/pyspelling/) to rectify spelling errors. The configuration for py-spelling can be found in [`.spellcheck.yml`](https://github.com/shopware/docs/blob/main/.spellcheck.yml). | ||||||
|
|
||||||
| #### Via Docker | ||||||
|
|
||||||
|
|
@@ -64,7 +64,7 @@ | |||||
|
|
||||||
| #### Excluding words | ||||||
|
|
||||||
| To exclude a word from being spellchecked, add it to the [`.wordlist.txt`](./.wordlist.txt) file. | ||||||
| To exclude a word from being spellchecked, add it to the [`.wordlist.txt`](https://github.com/shopware/docs/blob/main/.wordlist.txt) file. | ||||||
| Make sure to add the word at the right position, as the file doesn't automatically sort alphabetically. | ||||||
| You can use the following command to sort the file: | ||||||
|
|
||||||
|
|
@@ -74,15 +74,15 @@ | |||||
|
|
||||||
| ### Media file format check | ||||||
|
|
||||||
| The `/docs/assets` folder stores images, videos, and other files linked in markdown. They follow the naming convention outlined in [Methodize Assets](./resources/guidelines/documentation-guidelines/05-methodize-assets.md#visual-diagram-guidelines). The [`file-format-check.yml`](.github/workflows/file-format-check.yml) ensures adherence to these naming guidelines. | ||||||
| The `/docs/assets` folder stores images, videos, and other files linked in markdown. They follow the naming convention outlined in [Methodize Assets](./resources/guidelines/documentation-guidelines/05-methodize-assets.md#visual-diagram-guidelines). The [`file-format-check.yml`](https://github.com/shopware/docs/blob/main/.github/workflows/file-format-check.yml) ensures adherence to these naming guidelines. | ||||||
|
Check warning on line 77 in README.md
|
||||||
|
||||||
| The `/docs/assets` folder stores images, videos, and other files linked in markdown. They follow the naming convention outlined in [Methodize Assets](./resources/guidelines/documentation-guidelines/05-methodize-assets.md#visual-diagram-guidelines). The [`file-format-check.yml`](https://github.com/shopware/docs/blob/main/.github/workflows/file-format-check.yml) ensures adherence to these naming guidelines. | |
| The `assets/` folder stores images, videos, and other files linked in markdown. They follow the naming convention outlined in [Methodize Assets](./resources/guidelines/documentation-guidelines/05-methodize-assets.md#visual-diagram-guidelines). The [`file-format-check.yml`](https://github.com/shopware/docs/blob/main/.github/workflows/file-format-check.yml) ensures adherence to these naming guidelines. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,6 +117,6 @@ It is important to understand the difference between those two because both prov | |
|
|
||
| ## Configurator | ||
|
|
||
| When a variant product is loaded for a [Store API](../../api/store-api)-scoped request, Shopware assembles a configurator object which includes all different property groups and the corresponding variants. This way client applications, such as the [Storefront](../../../guides/plugins/plugins/storefront/) or [Composable Frontends](../../../../frontends/) can display the different variant options of the product. | ||
| When a variant product is loaded for a [Store API](../../api/store-api)-scoped request, Shopware assembles a configurator object which includes all different property groups and the corresponding variants. This way client applications, such as the [Storefront](../../../guides/plugins/plugins/storefront/) or [Composable Frontends](https://frontends.shopware.com/) can display the different variant options of the product. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why though? Aren't we migrating away from frontends.shopware.com? |
||
|
|
||
| The following section is a detailed understanding on category. | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -76,7 +76,7 @@ All those methods can be used in the same way. First, you pass the entity name t | |||||
| ### Search criteria | ||||||
|
|
||||||
| The search criteria define how the search is performed and what data is included. | ||||||
| The criteria object that is used inside the app scripts behaves and looks the same as the [JSON criteria used for the API](../../../integrations-api/general-concepts/search-criteria). | ||||||
| The criteria object that is used inside the app scripts behaves and looks the same as the [JSON criteria used for the API](../../../../guides/development/integrations-api/search-criteria). | ||||||
|
|
||||||
| So please refer to that documentation to get an overview of what features can be used inside a criteria object. | ||||||
|
|
||||||
|
|
@@ -113,7 +113,7 @@ One major difference is that when using the `repository` service, your app needs | |||||
|
|
||||||
| Refer to the [App Base Guide](../app-base-guide#permissions) for more information on how permissions work for apps. | ||||||
|
|
||||||
| The `repository` service exposes the same data as the CRUD-operations of the [Admin API](../../../integrations-api/#backend-facing-integrations---admin-api), whereas the `store` service gives access to the same data as the [Store API](../../../integrations-api/#customer-facing-interactions---store-api). | ||||||
| The `repository` service exposes the same data as the CRUD-operations of the [Admin API](../../../../guides/development/integrations-api/#backend-facing-integrations---admin-api), whereas the `store` service gives access to the same data as the [Store API](../../../../guides/development/integrations-api/#customer-facing-interactions---store-api). | ||||||
|
||||||
| The `repository` service exposes the same data as the CRUD-operations of the [Admin API](../../../../guides/development/integrations-api/#backend-facing-integrations---admin-api), whereas the `store` service gives access to the same data as the [Store API](../../../../guides/development/integrations-api/#customer-facing-interactions---store-api). | |
| The `repository` service exposes the same data as the CRUD-operations of the [Admin API](../../../../guides/development/integrations-api/#admin-api), whereas the `store` service gives access to the same data as the [Store API](../../../../guides/development/integrations-api/#store-api). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link label says
.reviewdog.yml, but the target points to.github/workflows/reviewdog.yml, and there is no.reviewdog.ymlfile in the repo. This is misleading and looks like a broken reference for readers—either update the label to match the actual file name/location or link to the real Reviewdog config if it exists elsewhere.