Draft
Conversation
45c0a95 to
4a5b659
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR represents the first step in refactoring the migration logging system. The changes focus on standardizing log entry creation and data collection while maintaining backward compatibility.
- Introduces a new
SwagMigrationLogBuilderfor consistent log entry creation across the system - Refactors
MigrationContextconstructor to improve parameter order and makeconnectiona required parameter - Simplifies fixture files by removing redundant source ID tracking and verbose log parameters
- Updates test files to use the modernized logging system and parameter structures
Reviewed Changes
Copilot reviewed 240 out of 244 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Various test snapshots | Updated to reflect simplified log structure without source ID tracking |
| Test files across Profile/ | Updated MigrationContext constructor calls with reordered parameters |
| Converter test files | Simplified assertion patterns for log codes without parameter validation |
| Gateway and media processing | Updated to use new logging builder pattern and simplified connection handling |
| Logging classes | Refactored to extend AbstractSwagMigrationLogEntry with simplified structure |
Comments suppressed due to low confidence (1)
tests/Profile/Shopware55/Converter/TranslationConverterTest.php:1
- This assertion is duplicated on line 437. The second assertion should likely check
$logs[3]['code']instead of$logs[2]['code']again, or verify a different aspect of the log entry.
<?php declare(strict_types=1);
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…to feature/migration-logging-refactor
Co-authored-by: Lars Kemper <l.kemper@shopware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves shopware/shopware#10417
fixes shopware/shopware#13898