Skip to content

ci: add nightly#163

Open
Lars Kemper (larskemper) wants to merge 23 commits intotrunkfrom
ci/add-nightly
Open

ci: add nightly#163
Lars Kemper (larskemper) wants to merge 23 commits intotrunkfrom
ci/add-nightly

Conversation

@larskemper
Copy link
Copy Markdown
Member

@larskemper Lars Kemper (larskemper) commented Mar 30, 2026 •
edited
Loading

resolves https://github.com/shopware/shopware-private/issues/214

Changes

  • refactored workflows to be reusable
  • added caching for npm dependencies
  • added concurrency groups (runners with old state get canceled)
  • added nightly.yml with slack notification
  • added reactivate-workflows.yml in case github deactivates workflows cause of inactivity

@larskemper Lars Kemper (larskemper) marked this pull request as ready for review April 1, 2026 07:36
@larskemper Lars Kemper (larskemper) changed the title ci: refactor & add nightly with fail notification ci: add nightly Apr 1, 2026
vintagesucks
Nikolas Evers (vintagesucks) approved these changes Apr 1, 2026
View reviewed changes
@larskemper Lars Kemper (larskemper) marked this pull request as draft April 1, 2026 15:58
vintagesucks
Nikolas Evers (vintagesucks) reviewed Apr 1, 2026
View reviewed changes
.github/workflows/action-acceptance.yml Outdated
DATABASE_URL: mysql://root:root@127.0.0.1:3306/shopware
steps:
- name: Cache npm
uses: actions/cache@v4
Copy link
Copy Markdown
Member

@vintagesucks Nikolas Evers (vintagesucks) Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/cache@v4
uses: actions/cache@v5

but do we also want to pin all our action versions to sha here?

Copy link
Copy Markdown
Member Author

@larskemper Lars Kemper (larskemper) Apr 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated to v5

but do we also want to pin all our action versions to sha here?

What is the benefit 😅 ?

Copy link
Copy Markdown
Member

@vintagesucks Nikolas Evers (vintagesucks) Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

uses: actions/cache@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4

https://docs.github.com/en/actions/reference/security/secure-use#using-third-party-actions

Pinning an action to a full-length commit SHA is currently the only way to use an action as an immutable release.

@v5 is just a tag: https://github.com/actions/cache/releases/tag/v5

Copy link
Copy Markdown
Member

@vintagesucks Nikolas Evers (vintagesucks) Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL: There even is a Require actions to be pinned to a full-length commit SHA setting, but I have no idea how that would behave in combination with our reusable workflows.

Copy link
Copy Markdown
Member Author

@larskemper Lars Kemper (larskemper) Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to know 🤝
I pinned them to 5.0.4

Copy link
Copy Markdown
Member Author

@larskemper Lars Kemper (larskemper) Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could try the setting and see what happens 😄

@larskemper Lars Kemper (larskemper) marked this pull request as ready for review April 1, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jozsefdamokos Jozsef Damokos (jozsefdamokos) Awaiting requested review from jozsefdamokos jozsefdamokos was automatically assigned from shopware/product-cc-after-sales

@DennisGarding Dennis Garding (DennisGarding) Awaiting requested review from DennisGarding DennisGarding was automatically assigned from shopware/product-cc-after-sales

@MalteJanz Malte Janz (MalteJanz) Awaiting requested review from MalteJanz MalteJanz was automatically assigned from shopware/product-cc-after-sales

@CR0YD Simon Fiebranz (CR0YD) Awaiting requested review from CR0YD CR0YD was automatically assigned from shopware/product-cc-after-sales

@ennasus4sun Susanne Hartung (ennasus4sun) Awaiting requested review from ennasus4sun ennasus4sun was automatically assigned from shopware/product-cc-after-sales

@vintagesucks Nikolas Evers (vintagesucks) Awaiting requested review from vintagesucks

At least 2 approving reviews are required to merge this pull request.

Assignees

@larskemper Lars Kemper (larskemper)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@larskemper @vintagesucks