feat: make previous fixes visible#162
Draft
Lars Kemper (larskemper) wants to merge 4 commits intotrunkfrom
Draft
feat: make previous fixes visible#162Lars Kemper (larskemper) wants to merge 4 commits intotrunkfrom
Lars Kemper (larskemper) wants to merge 4 commits intotrunkfrom
Conversation
Member
Author
Member
|
IMO if the user saved already lets say 100 fixes and 10 new show up on a rerun, the checkmark should be gone from the listing on the rerun and it should say 100/110. Then when he clicks on the modal he can easily filter for the new ones, so maybe tabs make sense. So option 2 |
Contributor
|
I would prefer option 1. It would be the proper UX someone would expect. Also imagine edge cases like this:
And if we allow proper editing of existing fixes, we don't need much additional UI, you can just display the same stuff on further migrations and its up to them to fix new issues or adjust existing ones. A way to filter / sort the listing for unfixed stuff would be great though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

resolves shopware/shopware#14721
tbd