refactor!: centralize configurations#158
Open
Lars Kemper (larskemper) wants to merge 7 commits intotrunkfrom
Open
refactor!: centralize configurations#158Lars Kemper (larskemper) wants to merge 7 commits intotrunkfrom
Lars Kemper (larskemper) wants to merge 7 commits intotrunkfrom
Conversation
Lars Kemper (larskemper)
requested review from
a team,
Simon Fiebranz (CR0YD),
Dennis Garding (DennisGarding),
Malte Janz (MalteJanz),
Susanne Hartung (ennasus4sun),
Jozsef Damokos (jozsefdamokos) and
Nikolas Evers (vintagesucks)
and removed request for
a team
Lars Kemper (larskemper)
force-pushed
the
feat/make-migration-assistant-configurable
branch
from
54a16d9 to
f368610
Compare
Dennis Garding (DennisGarding)
approved these changes
Mar 30, 2026
Jozsef Damokos (jozsefdamokos)
approved these changes
Mar 30, 2026
Nikolas Evers (vintagesucks)
approved these changes
Mar 31, 2026
Comment on lines
+22
to
+28
| public int $MIGRATION_LOG_BUFFER_SIZE = 50, | ||
| public int $MIGRATION_LOG_EXCEPTION_TRACE_ITEM_LIMIT = 10, | ||
| public int $MIGRATION_DEFAULT_BATCH_SIZE = 250, | ||
| public int $MIGRATION_MEDIA_PROCESSING_BATCH_SIZE = 10, | ||
| public int $MIGRATION_DEFAULT_EXCEPTION_THRESHOLD = 3, | ||
| public int $MIGRATION_DEFAULT_FETCH_SIZE = 50, | ||
| public int $MIGRATION_CONNECTION_TIMEOUT = 15, |
There was a problem hiding this comment.
SCREAMING_SNAKE_CASE feels a little weird for properties IMO
There was a problem hiding this comment.
UPGRADE.md still has the old naming
…assistant-configurable
Lars Kemper (larskemper)
force-pushed
the
feat/make-migration-assistant-configurable
branch
from
c38f589 to
1315b4b
Compare
Lars Kemper (larskemper)
requested review from
Malte Janz (MalteJanz) and
Nikolas Evers (vintagesucks)
Nikolas Evers (vintagesucks)
approved these changes
Apr 1, 2026
Malte Janz (MalteJanz)
requested changes
Apr 2, 2026
Contributor
Malte Janz (MalteJanz)
left a comment
Malte Janz (MalteJanz)
left a comment
There was a problem hiding this comment.
Besides the snapshot file change it looks good to me
Contributor
There was a problem hiding this comment.
why did this snapshot change?
| # NEXT | ||
|
|
||
| - #15568 - Switched to PHP Symfony service definitions | ||
| - #14598 - Introduced `MigrationConfiguration` service as a central place for internal configurations |
Contributor
There was a problem hiding this comment.
Nit: it's not user facing so no need to mention it here, it's enough to put it in the upgrade file for developers to not confuse any normal users
| # NEXT | ||
|
|
||
| - #15568 - Umstellung auf PHP-Symfony-Service-Definitionen | ||
| - #14598 - `MigrationConfiguration` als zentrale Stelle für interne Konfigurationen eingeführt |
Contributor
There was a problem hiding this comment.
Nit, see above. Same applies to the line above this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves shopware/shopware#14598
Changes
MigrationConfigurationservice (overridable by injection)