fix: selected counter in select all mode#131
Open
vintagesucks wants to merge 6 commits intofeature/migration-logging-refactorfrom
Open
fix: selected counter in select all mode#131vintagesucks wants to merge 6 commits intofeature/migration-logging-refactorfrom
vintagesucks wants to merge 6 commits intofeature/migration-logging-refactorfrom
Conversation
vintagesucks
requested review from
a team,
DennisGarding,
MalteJanz,
ennasus4sun,
jozsefdamokos and
larskemper
and removed request for
a team
larskemper
approved these changes
Feb 4, 2026
...tion/component/swag-migration-error-resolution/swag-migration-error-resolution-modal.spec.js
Outdated
Show resolved
Hide resolved
ennasus4sun
reviewed
Feb 5, 2026
...tion/component/swag-migration-error-resolution/swag-migration-error-resolution-modal.spec.js
Outdated
Show resolved
Hide resolved
larskemper
approved these changes
Feb 5, 2026
jozsefdamokos
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves shopware/shopware#14515
Introduces a
swag-migration-data-grid-extendedcomponent that extendssw-data-gridwith acustomSelectionCountprop, so the counter reflects the total count when "Select all" is active instead of only showing the current selection.