feat(ui-react): add admin user management pages#6086
feat(ui-react): add admin user management pages#6086
Conversation
|
Claude finished @luizhf42's task in 3m 19s —— View job Code Review CompleteReviewed 17 files across code quality, security, testing, TypeScript/React patterns, and architecture. 1 inline issue posted (high severity). Additional notes
If you've addressed the feedback and want a new review, tag |
4665e5b to
be4c821
Compare
|
OpenAPI spec gap for the missing |
4699c93 to
280b373
Compare
|
/review |
|
Claude finished @gustavosbarreto's task in 50s —— View job Code Review CompleteReviewed 17 files across code quality, security, testing, TypeScript/React patterns, and architecture. 2 inline issues posted (2 medium). Additional notes
If you've addressed the feedback and want a new review, tag |
1ace78c to
8b086b6
Compare
8b086b6 to
3809311
Compare
|
/review |
|
Claude finished @otavio's task in 6m 3s —— View job Code Review CompleteReviewed 17 files across code quality, security, testing, TypeScript/React patterns, and architecture — no issues found. The code looks good as-is. Additional notes
If you've addressed the feedback and want a new review, tag |
81c153e to
b351a36
Compare
|
/review |
|
Claude finished @gustavosbarreto's task in 19m 2s —— View job Code Review CompleteReviewed 24 files across code quality, security, testing, TypeScript/React patterns, and architecture — no issues found. The code looks good as-is. Additional notes
If you've addressed the feedback and want a new review, tag |
a6cec8b to
47cf669
Compare
Add query hooks (useAdminUsers, useAdminUser) with paginated list support, base64-encoded search filters, and admin-only guards. Add mutation hooks (useCreateUser, useUpdateUser, useDeleteUser, useResetUserPassword) with TanStack Query cache invalidation. Add isSdkErrorWithBody type guard for typed error handling of 400/409 API responses.
Add user list page with search, pagination, inline edit/delete actions, and login-as-user functionality. Add user detail page with identity/account info cards, edit drawer, create drawer, reset password dialog for SAML-only users, and delete confirmation. Register routes under /admin/users within the AdminRoute > LicenseGuard group.
b9a1786 to
613f966
Compare
What
Admin user list and detail pages for the React UI, covering CRUD operations, search, pagination, login-as-user impersonation, and SAML password reset.
Why
Implements features 3 and 4 from the admin panel roadmap (shellhub-io/team#93): User Administration and User Password Reset. The admin sidebar already links to
/admin/usersbut the pages didn't exist yet.Changes
isSdkErrorWithBodytype guard to replace unsafe double-casts (err as unknown as { body: string[] }) when handling 400/409 responses with field-level error arrays.type UserDetail = GetUserResponse & { admin?: boolean }to work around theadminfield being absent from the OpenAPI spec for the detail endpoint./admin/usersand/admin/users/:idroutes insideAdminRoute > LicenseGuard.Testing
1016 tests passing (162 new). Coverage includes hook behavior (query guards, cache invalidation, filter encoding), type guard edge cases, and component interaction flows (form submission, error states, state reset on reopen, accessibility attributes).