--theme: return a list of all themes if the theme argument doesn't match#3456
Open
monkeydom wants to merge 5 commits intosharkdp:masterfrom
Open
--theme: return a list of all themes if the theme argument doesn't match#3456monkeydom wants to merge 5 commits intosharkdp:masterfrom
monkeydom wants to merge 5 commits intosharkdp:masterfrom
Conversation
Author
|
Bump: please don't let this degrade again so much that you just flat out reject it because I'm not quick enough to respond. If you don't want the PR close it or take it. I know its just a little thing, but it was a quality of life improvement for my use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turns:
[bat warning]: Unknown theme 'SolarizedDark', using default.Into a more actionable:
[bat warning]: Unknown theme 'SolarizedDark', using default. (Available themes: 1337, Coldark-Cold, Coldark-Dark, DarkNeon, Dracula, GitHub, Monokai Extended, Monokai Extended Bright, Monokai Extended Light, Monokai Extended Origin, Nord, OneHalfDark, OneHalfLight, Solarized (dark), Solarized (light), Sublime Snazzy, TwoDark, Visual Studio Dark+, ansi, base16, base16-256, gruvbox-dark, gruvbox-light, zenburn)Might be worth doing a fuzzy prefix match too maybe?