Skip to content

Comments

fix: group mobile trade tabs to prevent overflow in translated locales#11973

Merged
0xApotheosis merged 3 commits intodevelopfrom
fix/ss-5535-mobile-trade-toggle
Feb 23, 2026
Merged

fix: group mobile trade tabs to prevent overflow in translated locales#11973
0xApotheosis merged 3 commits intodevelopfrom
fix/ss-5535-mobile-trade-toggle

Conversation

@premiumjibles
Copy link
Collaborator

@premiumjibles premiumjibles commented Feb 20, 2026

Description

The mobile trade page header showed all 5 tab options (Swap, Limit, Buy, Sell, Earn) as individual pill buttons in a single horizontal row. In languages with longer labels (German, French, etc.), these overflowed off both edges of the screen.

This adopts the same grouping strategy already used on desktop: 3 pills (Swap, Buy/Sell, Earn) with dropdown toggles for sub-options (Market/Limit, Buy/Sell).

Issue (if applicable)

closes #SS-5535

Risk

Low risk — UI-only change scoped to mobile viewport. No new state, callbacks, or business logic introduced. Reuses existing toggle handlers and labels already defined in the component.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None. This is a pure UI layout change.

Testing

Engineering

  1. Open the app in a mobile viewport (< 768px)
  2. Confirm only 3 pill buttons are visible: Swap, Buy/Sell, Earn
  3. When Swap pill is active, a Market/Limit toggle should appear below (if LimitOrders feature flag is on)
  4. When Buy/Sell pill is active, a Buy/Sell toggle should appear below
  5. Toggle buttons should switch sub-modes correctly
  6. Test with German/French locale to confirm no overflow
  7. Verify desktop layout is unchanged
  8. Make sure additional toggle doesn't break the UI vertically on mobile (things on the bottom of the screen don't get pushed down and become inaccessible)

Operations

  • Test on mobile viewport that tabs don't overflow in any language
  • Verify toggle dropdowns switch between Market/Limit and Buy/Sell correctly

Screenshots (if applicable)

https://jam.dev/c/76b60627-67a4-48f4-b747-edc034f88912

The mobile trade page header showed all 5 tab options (Swap, Limit, Buy,
Sell, Earn) as individual pills, which overflowed off-screen in languages
with longer labels (German, French, etc.). This adopts the same grouping
strategy already used on desktop: 3 pills (Swap, Buy/Sell, Earn) with
dropdown toggles for sub-options (Market/Limit, Buy/Sell).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

Warning

Rate limit exceeded

@premiumjibles has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ss-5535-mobile-trade-toggle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@premiumjibles premiumjibles marked this pull request as ready for review February 20, 2026 23:34
@premiumjibles premiumjibles requested a review from a team as a code owner February 20, 2026 23:34
@premiumjibles premiumjibles marked this pull request as draft February 20, 2026 23:47
@premiumjibles premiumjibles marked this pull request as ready for review February 20, 2026 23:51
Copy link
Member

@0xApotheosis 0xApotheosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, gm

@0xApotheosis 0xApotheosis merged commit 276c4d1 into develop Feb 23, 2026
4 checks passed
@0xApotheosis 0xApotheosis deleted the fix/ss-5535-mobile-trade-toggle branch February 23, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants