Skip to content

Comments

fix: trade bottom nav active state for all sub-tabs#11971

Open
premiumjibles wants to merge 2 commits intodevelopfrom
fix/ss-5536-trade-nav-active-state
Open

fix: trade bottom nav active state for all sub-tabs#11971
premiumjibles wants to merge 2 commits intodevelopfrom
fix/ss-5536-trade-nav-active-state

Conversation

@premiumjibles
Copy link
Collaborator

@premiumjibles premiumjibles commented Feb 20, 2026

Description

The Trade tab in the mobile bottom navigation only showed as active for the Swap (/trade) and Limit (/limit) routes. Clicking Buy, Sell, or Earn sub-tabs navigated to /ramp/trade/* and /earn/* respectively, which were missing from the relatedPaths array used by MobileNavLink for active state matching.

Changes:

  • Added /ramp/trade and /earn to the Trade route's relatedPaths array in RoutesCommon.tsx
  • Fixed the mobile header title to use common.trade ("Trade") instead of transactionRow.swap ("Swap") for consistency with the bottom nav label

Issue (if applicable)

closes #11964

Risk

Near zero — only affects mobile bottom nav active state styling and a translation key for the mobile page title. No transaction logic, wallet interactions, or protocol changes.

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None.

Testing

Engineering

  1. Open the app on mobile (or use responsive mode in DevTools)
  2. Tap the Trade bottom nav tab
  3. Tap through each sub-tab: Swap, Limit, Buy, Sell, Earn
  4. Verify the Trade icon in the bottom nav stays active/highlighted for all five sub-tabs
  5. Verify the mobile page header says "Trade" (not "Swap")

Operations

  • Open mobile app, connect wallet
  • Tap Trade in bottom nav — verify it's highlighted
  • Tap each sub-tab (Swap, Limit, Buy, Sell, Earn) — verify Trade stays highlighted in bottom nav for all
  • Verify the page title reads "Trade" on mobile

Screenshots (if applicable)

Demo

https://jam.dev/c/76b60627-67a4-48f4-b747-edc034f88912

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 20, 2026

Warning

Rate limit exceeded

@premiumjibles has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ss-5536-trade-nav-active-state

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

The Trade tab in mobile bottom navigation only showed as active for
Swap and Limit routes. Buy, Sell, and Earn sub-tabs navigated to
/ramp/trade/* and /earn/* which were missing from the relatedPaths
array used for active state matching.

Also fixes the mobile header title using 'Swap' instead of 'Trade'
to match the bottom nav label.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@premiumjibles premiumjibles force-pushed the fix/ss-5536-trade-nav-active-state branch from 365d0ca to 38e1bbf Compare February 20, 2026 11:45
@premiumjibles premiumjibles marked this pull request as ready for review February 20, 2026 23:33
@premiumjibles premiumjibles requested a review from a team as a code owner February 20, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trade Page bottom navigation should be active for all selected option on page

1 participant