Merging contribution from shpingalet007 to remove 'prefixOnly'#6
Open
shanegenschaw wants to merge 6 commits intomasterfrom
Open
Merging contribution from shpingalet007 to remove 'prefixOnly'#6shanegenschaw wants to merge 6 commits intomasterfrom
shanegenschaw wants to merge 6 commits intomasterfrom
Conversation
Trigger in middle of comment works very unstable. Removing prefixOnly and related functionality
shanegenschaw
force-pushed
the
remove-prefixonly
branch
from
ae76333 to
a5c0af1
Compare
Owner
Author
|
I'm thinking maybe this should be a major version bump ( |
shanegenschaw
force-pushed
the
remove-prefixonly
branch
from
a5c0af1 to
2077005
Compare
shpingalet007
approved these changes
Aug 10, 2023
Collaborator
shpingalet007
left a comment
shpingalet007
left a comment
There was a problem hiding this comment.
Looks good. The only difference is that you don't use --minify flag for NCC, but it doesn't matter in sense of functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-merging Khan#34 with contribution from shpingalet007 to remove the
prefixOnlyflag. See comment with explanation.