fix: harden numeric conversions for gosec#74
Merged
Merged
Conversation
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
- Coverage 98.30% 95.57% -2.74%
==========================================
Files 72 73 +1
Lines 6123 6366 +243
==========================================
+ Hits 6019 6084 +65
- Misses 71 167 +96
- Partials 33 115 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #65
Summary
G115/G103findingsErrValueOutOfRangeinstead of silently overflowing integer decodesBackground / Motivation
This change addresses gosec findings around integer conversions and unsafe usage, while preventing silent overflow when decoding MessagePack numeric values.
Changes
internal/common/decodingutilfor checked int/uint conversionsencoding/binaryand shared buffer helpersunsafeusage from string encodingTest Plan
go test ./...ErrValueOutOfRange