Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions prototypes/docusaurus/docusaurus.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const packageFooterItems = packages.map((pkg) => {
const config: Config = {
title: 'React on Rails',
tagline: 'Integrate React with Rails, including SSR, RSC, and production-grade docs.',
favicon: 'img/logo-mark.png',
favicon: 'img/favicon.ico',

future: {
v4: true,
Expand Down Expand Up @@ -119,7 +119,7 @@ const config: Config = {
title: 'React on Rails',
logo: {
alt: 'React on Rails Logo',
src: 'img/logo-mark.png',
src: 'img/icon-tile.svg',
width: 40,
height: 40,
},
Expand Down
4 changes: 2 additions & 2 deletions prototypes/docusaurus/src/pages/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ function TrustedBySection() {
}

function HeroSection() {
const heroLogoSrc = useBaseUrl('/img/logo-mark.png');
const heroLogoSrc = useBaseUrl('/img/icon-tile.svg');

return (
<header className={styles.heroBanner}>
Expand Down Expand Up @@ -227,7 +227,7 @@ function LiveDemosSection() {
}

function ProSection() {
const proLogoSrc = useBaseUrl('/img/logo-mark-pro.svg');
const proLogoSrc = useBaseUrl('/img/icon-tile.svg');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pro section alt mismatches image

Low Severity

The Pro feature block now uses the same icon-tile.svg mark as the hero, but the image alt still says it is a distinct Pro logo. That text no longer matches what is shown after retiring the Pro badge artwork.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2fe6a3e. Configure here.


return (
<section className={styles.sectionFeature}>
Expand Down
2 changes: 2 additions & 0 deletions prototypes/docusaurus/src/pages/pro.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type {ReactNode} from 'react';
import Link from '@docusaurus/Link';
import Layout from '@theme/Layout';
import {PageMetadata} from '@docusaurus/theme-common';

import {docsRoutes} from '../constants/docsRoutes';
import styles from './pro.module.css';
Expand Down Expand Up @@ -85,6 +86,7 @@ const upgradeSteps = [
export default function ProPage(): ReactNode {
return (
<Layout title="React on Rails Pro" description="React on Rails Pro features and upgrade path">
<PageMetadata image="img/react-on-rails-pro-social-card.png" />
<main className={styles.main}>
<section className={styles.hero}>
<div className="container">
Expand Down
Binary file not shown.
Binary file modified prototypes/docusaurus/static/img/favicon.ico
Binary file not shown.
Binary file modified prototypes/docusaurus/static/img/icon-192.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified prototypes/docusaurus/static/img/icon-512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
23 changes: 23 additions & 0 deletions prototypes/docusaurus/static/img/icon-tile.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added prototypes/docusaurus/static/img/lockup-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 26 additions & 0 deletions prototypes/docusaurus/static/img/lockup-dark.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added prototypes/docusaurus/static/img/lockup-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 26 additions & 0 deletions prototypes/docusaurus/static/img/lockup-light.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
33 changes: 0 additions & 33 deletions prototypes/docusaurus/static/img/logo-lockup-dark.svg

This file was deleted.

33 changes: 0 additions & 33 deletions prototypes/docusaurus/static/img/logo-lockup-light.svg

This file was deleted.

Binary file removed prototypes/docusaurus/static/img/logo-mark-pro.png
Binary file not shown.
32 changes: 0 additions & 32 deletions prototypes/docusaurus/static/img/logo-mark-pro.svg

This file was deleted.

Binary file removed prototypes/docusaurus/static/img/logo-mark.png
Binary file not shown.
28 changes: 0 additions & 28 deletions prototypes/docusaurus/static/img/logo-mark.svg

This file was deleted.

Binary file removed prototypes/docusaurus/static/img/logo.png
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
22 changes: 22 additions & 0 deletions prototypes/docusaurus/static/img/mark-transparent.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified prototypes/docusaurus/static/img/react-on-rails-social-card.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading