Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ruby "3.4.6"

gem "cpflow", "5.2.0", require: false
gem "react_on_rails_pro", "17.0.0"
gem "shakapacker", "10.2.0"
gem "shakapacker", "10.3.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the Shakapacker npm package with the gem

This changes only the Ruby gem, but package.json still pins the JS package at shakapacker 10.2.0 and the webpack configs load that package via require('shakapacker') (for example config/webpack/commonWebpackConfig.js:6). Any bin/shakapacker or dev-server build after yarn install will therefore run Ruby Shakapacker 10.3 with JS Shakapacker 10.2, an unsupported mismatch that can cause build failures or skip the JS-side fixes from 10.3. Please update package.json and yarn.lock in the same change.

Useful? React with 👍 / 👎.


# Bundle edge Rails instead: gem "rails", github: "rails/rails"
gem "rails", "~> 8.1.2"
Expand All @@ -32,7 +32,7 @@ gem "coffee-rails"

# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem "jbuilder"
gem "redis", "~> 5.0"
gem "redis", "~> 5.4"

# bundle exec rake doc:rails generates the API under doc/api.
gem "sdoc", group: :doc
Expand Down Expand Up @@ -71,10 +71,10 @@ group :development, :test do

################################################################################
# Linters and Security
gem "rubocop", "1.69", require: false
gem "rubocop-performance", "1.23.1", require: false
gem "rubocop-rails", "2.29.1", require: false
gem "rubocop-rspec", "3.4.0", require: false
gem "rubocop", "1.88.2", require: false
gem "rubocop-performance", "1.26.1", require: false
gem "rubocop-rails", "2.36.0", require: false
gem "rubocop-rspec", "3.10.2", require: false
# Critical that require: false be set! https://github.com/brigade/scss-lint/issues/278
gem "scss_lint", require: false

Expand All @@ -97,12 +97,12 @@ end
group :test do
gem "capybara"
gem "capybara-screenshot"
gem "coveralls_reborn", "~> 0.25.0", require: false
gem "coveralls_reborn", "~> 1.0.0", require: false
gem "database_cleaner"
gem "generator_spec"
gem "launchy"
gem "rails_best_practices"
gem "rspec-rails", "~> 6.0.0"
gem "rspec-rails", "~> 8.0.4"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep RSpec config compatible with rspec-rails 8

With rspec-rails 8, the Rails fixture setting is fixture_paths rather than fixture_path; this repo still calls config.fixture_path = Rails.root.join("spec/fixtures") in spec/rails_helper.rb:49. Any bundle exec rspec run that loads rails_helper will fail during boot with NoMethodError before examples run unless the helper is updated to the plural setting or the dependency stays on a compatible 6.x release.

Useful? React with 👍 / 👎.

gem "selenium-webdriver", "~> 4"
end

Expand Down
Loading
Loading