Skip to content

Fix SSR renderer URL VM global #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 2 commits into from
Jul 14, 2026
Merged

Fix SSR renderer URL VM global #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f2ee3c
fix: provide URL to SSR renderer VM
justin808 Jul 14, 2026
2f24def
test: use parsed SSR response body
justin808 Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions renderer/node-renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const path = require('path');
const { URL } = require('node:url');
const { reactOnRailsProNodeRenderer } = require('react-on-rails-pro-node-renderer');

const isProduction = process.env.NODE_ENV === 'production';
Expand Down
7 changes: 7 additions & 0 deletions spec/requests/server_render_check_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
.to include("Comments")
end

it "server renders RouterApp NavLinks that require the URL VM global" do
get root_path
html_nodes = response.parsed_body

expect(html_nodes.at_css("#RouterApp-react-component-0 a[href='/react-router']").text).to eq("Route")
end

it "generates no server rendered HTML if server rendering not enabled" do
get simple_path
html_nodes = Nokogiri::HTML(response.body)
Expand Down
Loading