Fix the dev build: compileSdk 37 and Hilt 2.60.1 - #2162
Merged
mpretty-cyro merged 1 commit intoAug 12, 2026
Conversation
Two independent dependabot bumps each broke the build on dev, and the first masked the second. - compileSdk 36 -> 37, required by lifecycle 2.11.0 (session-foundation#2157), which fails checkAarMetadata below 37. targetSdk stays at 36. Reverting session-foundation#2157 was considered and declined: compileSdk is a change we control. Note there is no `platforms;android-37` package — it is android-37.0, and AGP resolves compileSdk = 37 to it with no compileSdkMinor needed. - Dagger/Hilt 2.59.2 -> 2.60.1, to read the 2.4.0 class metadata that coil 3.5.0 (session-foundation#2159) pulls in via kotlin-stdlib 2.4.0; 2.59.2's bundled reader caps at 2.3.0 and failed hiltJavaCompile. Kotlin stays at 2.3.20 deliberately — bumping it would emit 2.4.0 metadata from our own classes too. CI provisions no Android SDK (no setup step in build_and_test.yml, and gradle.properties sets no sdkDownload flag), so it relies on the runner image plus AGP auto-download. If the image lacks android-37.0, CI will fail on the SDK and that reads as unrelated to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent dependabot bumps each broke the build on dev, and the first masked the second.
platforms;android-37package — it is android-37.0, and AGP resolves compileSdk = 37 to it with no compileSdkMinor needed.CI provisions no Android SDK (no setup step in build_and_test.yml, and gradle.properties sets no sdkDownload flag), so it relies on the runner image plus AGP auto-download. If the image lacks android-37.0, CI will fail on the SDK and that reads as unrelated to this change.