Skip to content

fix: don't load session_util from ProStatusManager class init #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bilb wants to merge 1 commit into from
Closed

fix: don't load session_util from ProStatusManager class init #2154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions app/src/main/java/org/thoughtcrime/securesms/pro/ProStatusManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,9 +491,15 @@ class ProStatusManager @Inject constructor(
}

companion object {
// Single-sourced from libsession (see SessionProtocol) rather than hard-coded here.
val MAX_CHARACTER_PRO = SessionProtocol.PRO_HIGHER_CHARACTER_LIMIT // max message codepoints for pro users
private val MAX_CHARACTER_REGULAR = SessionProtocol.STANDARD_CHARACTER_LIMIT // max message codepoints for non-pro users
// Single-sourced from libsession (see SessionProtocol) rather than hard-coded here. Read
// through getters, not stored in the initialiser: touching SessionProtocol loads the
// session_util native library, and doing that from ProStatusManager's <clinit> makes the
// class impossible to even load (let alone mock) on the JVM, where there is no native
// library. SessionProtocol already caches both values, so this stays a cheap field read.
val MAX_CHARACTER_PRO: Int // max message codepoints for pro users
get() = SessionProtocol.PRO_HIGHER_CHARACTER_LIMIT
private val MAX_CHARACTER_REGULAR: Int // max message codepoints for non-pro users
get() = SessionProtocol.STANDARD_CHARACTER_LIMIT
const val MAX_PIN_REGULAR = 5 // max pinned conversation for non pro users

const val URL_PRO_SUPPORT = "https://getsession.org/pro-form"
Expand Down
Loading