Skip to content

Do not notify if decryption fails#2079

Merged
SessionHero01 merged 1 commit intodevfrom
remove-redundant-notification
Mar 25, 2026
Merged

Do not notify if decryption fails#2079
SessionHero01 merged 1 commit intodevfrom
remove-redundant-notification

Conversation

@SessionHero01
Copy link
Copy Markdown
Collaborator

@SessionHero01 SessionHero01 commented Mar 25, 2026

Decryption fail doesn't warrant a notification, here's why:

  1. A failured decryption can't add the message to any conversation. Bringing up the app won't show anything different so it will just confuse the user.
  2. Decryption fail happens more than you think, especially with exited groups.

@SessionHero01 SessionHero01 merged commit 070142f into dev Mar 25, 2026
5 checks passed
@SessionHero01 SessionHero01 deleted the remove-redundant-notification branch March 25, 2026 06:27
SessionHero01 added a commit that referenced this pull request Mar 27, 2026
@SessionHero01
Revert "Do not notify if decryption fails (#2079)"
2f3651c 
This reverts commit 070142f.
SessionHero01 added a commit that referenced this pull request Mar 27, 2026
@SessionHero01
Revert "Do not notify if decryption fails (#2079)" (#2085)
5dc21f0 
This reverts commit 070142f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomasSession ThomasSession ThomasSession approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SessionHero01 @ThomasSession