DO NOT MERGE — verify macOS build with libsession-util#120 - #67
Closed
Bilb wants to merge 1 commit into
Closed
Conversation
Throwaway branch to run the macOS matrix against session-foundation/libsession-util#120 before merging it. Pins the submodule to b63b4b0d and temporarily points its URL at the public fork, since the fix commit is not on a branch in the upstream libsession-util repo. Must not be merged: it would redirect the libsession-util submodule to a personal fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway branch to prove that session-foundation/libsession-util#120 fixes the macOS build failure, before merging it.
What this pins
libsession-utilsubmodule →b63b4b0d(the fix commit from libsession-util#120).gitmodulesURL →https://github.com/Bilb/libsession-util.git(temporary)The URL override is only needed because the fix commit isn't on a branch in the upstream
libsession-utilrepo — it exists as the PR head, andgit submodule updatefetchesrefs/heads/*, notrefs/pull/*. The fork is public, so the runners can clone it.What to look at
The
macos-15-intelandmacos-14jobs, specifically the build libsession-util-nodejs step (pnpm install --frozen-lockfile), which compilessrc/pro_backend.cpp. That's the step that fails ondevtoday with:Also worth a glance: confirm that step actually recompiles
pro_backend.cpprather than restoring it from the fallback ccache key.Follow-up
Once macOS is green: merge libsession-util#120, re-pin the submodule to the new
devtip on a normal branch, and close this PR without merging. Merging it would redirect the submodule to a personal fork for everyone.